chrome/browser/push_messaging/push_messaging_service_observer_android.cc - Issue 2146753002: Android: Remove unneeded RegisterNatives() calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_service_observer_android.cc

Issue 2146753002: Android: Remove unneeded RegisterNatives() calls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Android: Don't require RegisterNatives if there are none Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_service_observer_android.h ('k') | chrome/browser/supervised_user/child_accounts/child_account_feedback_reporter_android.h » ('j') | net/android/cellular_signal_strength.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_service_observer_android.cc

diff --git a/chrome/browser/push_messaging/push_messaging_service_observer_android.cc b/chrome/browser/push_messaging/push_messaging_service_observer_android.cc

index affbcaab3a4385b922e7b24b9b871cd57187c595..449d6350f45a542fc00fa5e69e4f48407c21eb33 100644

--- a/chrome/browser/push_messaging/push_messaging_service_observer_android.cc

+++ b/chrome/browser/push_messaging/push_messaging_service_observer_android.cc

@@ -7,11 +7,6 @@

#include "base/android/jni_android.h"

#include "jni/PushMessagingServiceObserver_jni.h"

-// static

-bool PushMessagingServiceObserverAndroid::RegisterJni(JNIEnv* env) {

- return chrome::android::RegisterNativesImpl(env);

void PushMessagingServiceObserverAndroid::OnMessageHandled() {

chrome::android::Java_PushMessagingServiceObserver_onMessageHandled(

base::android::AttachCurrentThread());