Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: components/bookmarks.gypi

Issue 2146753002: Android: Remove unneeded RegisterNatives() calls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Android: Don't require RegisterNatives if there are none Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 # GN version: //components/bookmarks/browser 8 # GN version: //components/bookmarks/browser
9 'target_name': 'bookmarks_browser', 9 'target_name': 'bookmarks_browser',
10 'type': 'static_library', 10 'type': 'static_library',
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 # In GN, this android-specific stuff is its own target at 69 # In GN, this android-specific stuff is its own target at
70 # //components/bookmarks/common/android 70 # //components/bookmarks/common/android
71 # TODO(cjhopman): This should be its own target in Gyp, too. 71 # TODO(cjhopman): This should be its own target in Gyp, too.
72 'dependencies': [ 72 'dependencies': [
73 'bookmarks_jni_headers', 73 'bookmarks_jni_headers',
74 ], 74 ],
75 'sources' : [ 75 'sources' : [
76 'bookmarks/common/android/bookmark_id.cc', 76 'bookmarks/common/android/bookmark_id.cc',
77 'bookmarks/common/android/bookmark_id.h', 77 'bookmarks/common/android/bookmark_id.h',
78 'bookmarks/common/android/bookmark_type_list.h', 78 'bookmarks/common/android/bookmark_type_list.h',
79 'bookmarks/common/android/component_jni_registrar.cc',
80 'bookmarks/common/android/component_jni_registrar.h',
81 ], 79 ],
82 }], 80 }],
83 ['toolkit_views==1', { 81 ['toolkit_views==1', {
84 'dependencies': [ 82 'dependencies': [
85 '<(DEPTH)/ui/views/views.gyp:views', 83 '<(DEPTH)/ui/views/views.gyp:views',
86 ], 84 ],
87 }], 85 }],
88 ['use_x11==1', { 86 ['use_x11==1', {
89 'dependencies': [ 87 'dependencies': [
90 '../ui/events/platform/x11/x11_events_platform.gyp:x11_events_platfo rm', 88 '../ui/events/platform/x11/x11_events_platform.gyp:x11_events_platfo rm',
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 'type': 'none', 194 'type': 'none',
197 'variables': { 195 'variables': {
198 'source_file': 'bookmarks/common/android/bookmark_type.h', 196 'source_file': 'bookmarks/common/android/bookmark_type.h',
199 }, 197 },
200 'includes': [ '../build/android/java_cpp_enum.gypi' ], 198 'includes': [ '../build/android/java_cpp_enum.gypi' ],
201 }, 199 },
202 ], 200 ],
203 }] 201 }]
204 ], 202 ],
205 } 203 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698