chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.h - Issue 2146753002: Android: Remove unneeded RegisterNatives() calls

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.h

Issue 2146753002: Android: Remove unneeded RegisterNatives() calls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Android: Don't require RegisterNatives if there are none Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/lifetime/application_lifetime_android.cc ('k') | chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc » ('j') | net/android/cellular_signal_strength.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ANDROID_PAGE_LOAD_METRICS_OBS ERVER_H_	5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ANDROID_PAGE_LOAD_METRICS_OBS ERVER_H_

6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ANDROID_PAGE_LOAD_METRICS_OBS ERVER_H_	6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ANDROID_PAGE_LOAD_METRICS_OBS ERVER_H_

7	7

8 #include <jni.h>	8 #include <jni.h>

9	9

10 #include "base/macros.h"	10 #include "base/macros.h"

(...skipping 15 matching lines...) Expand all Loading...
26 void OnFirstContentfulPaint(	26 void OnFirstContentfulPaint(

27 const page_load_metrics::PageLoadTiming& timing,	27 const page_load_metrics::PageLoadTiming& timing,

28 const page_load_metrics::PageLoadExtraInfo& extra_info) override;	28 const page_load_metrics::PageLoadExtraInfo& extra_info) override;

29	29

30 private:	30 private:

31 content::WebContents* web_contents_;	31 content::WebContents* web_contents_;

32	32

33 DISALLOW_COPY_AND_ASSIGN(AndroidPageLoadMetricsObserver);	33 DISALLOW_COPY_AND_ASSIGN(AndroidPageLoadMetricsObserver);

34 };	34 };

35	35

36 bool RegisterPageLoadMetricsBindings(JNIEnv* env);

37

38 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ANDROID_PAGE_LOAD_METRICS_ OBSERVER_H_	36 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_ANDROID_PAGE_LOAD_METRICS_ OBSERVER_H_

OLD	NEW