Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 2146743002: Remove focus from base page when OverlayPanel open (Closed)

Created:
4 years, 5 months ago by mdjones
Modified:
4 years, 5 months ago
Reviewers:
Theresa
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove focus from base page when OverlayPanel open Doing this causes any open controls including autofill to be closed. BUG=622603 Committed: https://crrev.com/40ebdf14009d82bd62d31cf322e063e919d37ffa Cr-Commit-Position: refs/heads/master@{#405198}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mdjones
Even though focus does not stay on the OverlayPanel, it is enough to clear open ...
4 years, 5 months ago (2016-07-13 01:01:03 UTC) #2
Theresa
lgtm
4 years, 5 months ago (2016-07-13 16:09:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146743002/1
4 years, 5 months ago (2016-07-13 16:09:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 16:59:20 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:01:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40ebdf14009d82bd62d31cf322e063e919d37ffa
Cr-Commit-Position: refs/heads/master@{#405198}

Powered by Google App Engine
This is Rietveld 408576698