Remove USE_OZONE in video files

Remove USE_OZONE in video files

Currently all chromebooks have USE_V4L2_CODEC use flag.
We should use this instead of depending USE_OZONE to enable V4L2
devices.

BUG=627480
TEST=vea unittest pass, apprtc use hw encode/decode

Committed: https://crrev.com/5580c3ab2104c612abf89283d76239e5c26ef672
Cr-Commit-Position: refs/heads/master@{#405436}

[henryhsu, 2016-07-13 04:43:26]

henryhsu@chromium.org changed reviewers:
+ piman@chromium.org, posciak@chromium.org, wuchengli@chromium.org

[henryhsu, 2016-07-13 04:43:27]

PTAL

[wuchengli, 2016-07-13 08:23:59]

https://codereview.chromium.org/2146733003/diff/1/content/common/BUILD.gn
File content/common/BUILD.gn (right):

https://codereview.chromium.org/2146733003/diff/1/content/common/BUILD.gn#new...
content/common/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All rights
reserved.
Explain in the change description about why we are doing this.

https://codereview.chromium.org/2146733003/diff/1/content/common/sandbox_linu...
File content/common/sandbox_linux/bpf_gpu_policy_linux.cc (right):

https://codereview.chromium.org/2146733003/diff/1/content/common/sandbox_linu...
content/common/sandbox_linux/bpf_gpu_policy_linux.cc:346: } else if
(IsArchitectureArm() || UseV4L2Codec()){
We don't need IsArchitectureArm() here. Right?

https://codereview.chromium.org/2146733003/diff/1/media/gpu/ipc/client/BUILD.gn
File media/gpu/ipc/client/BUILD.gn (right):

https://codereview.chromium.org/2146733003/diff/1/media/gpu/ipc/client/BUILD....
media/gpu/ipc/client/BUILD.gn:15: configs += [ "//media/gpu:gpu_config" ]
Merge this with configs in the next line.

[henryhsu, 2016-07-13 08:42:52]

Description was changed from

==========
Remove USE_OZONE in video files

BUG=627480
TEST=vea unittest pass, apprtc use hw encode/decode
==========

to

==========
Remove USE_OZONE in video files

Currently all chromebooks have USE_V4L2_CODEC use flag.
We should use this instead of depending USE_OZONE to enable V4L2
devices.

BUG=627480
TEST=vea unittest pass, apprtc use hw encode/decode
==========

[henryhsu, 2016-07-13 08:43:28]

https://codereview.chromium.org/2146733003/diff/1/content/common/BUILD.gn
File content/common/BUILD.gn (right):

https://codereview.chromium.org/2146733003/diff/1/content/common/BUILD.gn#new...
content/common/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All rights
reserved.
On 2016/07/13 08:23:59, wuchengli wrote:
> Explain in the change description about why we are doing this.

Done.

https://codereview.chromium.org/2146733003/diff/1/content/common/sandbox_linu...
File content/common/sandbox_linux/bpf_gpu_policy_linux.cc (right):

https://codereview.chromium.org/2146733003/diff/1/content/common/sandbox_linu...
content/common/sandbox_linux/bpf_gpu_policy_linux.cc:346: } else if
(IsArchitectureArm() || UseV4L2Codec()){
On 2016/07/13 08:23:59, wuchengli wrote:
> We don't need IsArchitectureArm() here. Right?

Yes

https://codereview.chromium.org/2146733003/diff/1/media/gpu/ipc/client/BUILD.gn
File media/gpu/ipc/client/BUILD.gn (right):

https://codereview.chromium.org/2146733003/diff/1/media/gpu/ipc/client/BUILD....
media/gpu/ipc/client/BUILD.gn:15: configs += [ "//media/gpu:gpu_config" ]
On 2016/07/13 08:23:59, wuchengli wrote:
> Merge this with configs in the next line.

Done.

[wuchengli, 2016-07-13 08:50:25]

lgtm

https://codereview.chromium.org/2146733003/diff/20001/media/gpu/ipc/client/BU...
File media/gpu/ipc/client/BUILD.gn (right):

https://codereview.chromium.org/2146733003/diff/20001/media/gpu/ipc/client/BU...
media/gpu/ipc/client/BUILD.gn:16: "//media/gpu:gpu_config",
Put this after //build to follow alphabetical order.

[henryhsu, 2016-07-13 08:56:21]

henryhsu@chromium.org changed reviewers:
+ jorgelo@chromium.org

[henryhsu, 2016-07-13 08:56:22]

Hi jorgelo@, please help review bpf_gpu_policy_linux.cc
Hi piman@, please help review content/common/BUILD.gn
Thanks.

[Jorge Lucangeli Obes, 2016-07-13 13:09:18]

https://codereview.chromium.org/2146733003/diff/40001/content/common/sandbox_...
File content/common/sandbox_linux/bpf_gpu_policy_linux.cc (left):

https://codereview.chromium.org/2146733003/diff/40001/content/common/sandbox_...
content/common/sandbox_linux/bpf_gpu_policy_linux.cc:346: } else if
(IsArchitectureArm() || IsOzone()){
Why did you remove IsArchitectureArm?

[wuchengli, 2016-07-13 13:26:04]

https://codereview.chromium.org/2146733003/diff/40001/content/common/sandbox_...
File content/common/sandbox_linux/bpf_gpu_policy_linux.cc (left):

https://codereview.chromium.org/2146733003/diff/40001/content/common/sandbox_...
content/common/sandbox_linux/bpf_gpu_policy_linux.cc:346: } else if
(IsArchitectureArm() || IsOzone()){
On 2016/07/13 13:09:17, Jorge Lucangeli Obes wrote:
> Why did you remove IsArchitectureArm?
We now use USE_V4L2_CODEC to decide if a device can have V4L2 video device. All
ChromeOS devices, ARM or Intel, have USE_V4L2_CODEC. That is passed from
ChromeOS build system. So USE_V4L2_CODEC is the only thing we need to check.

[Jorge Lucangeli Obes, 2016-07-13 13:27:50]

bpf_gpu_policy_linux.cc LGTM

[piman, 2016-07-13 18:48:04]

lgtm

[henryhsu, 2016-07-14 02:08:58]

The CQ bit was checked by henryhsu@chromium.org

[henryhsu, 2016-07-14 02:08:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
wuchengli@chromium.org
Link to the patchset: https://codereview.chromium.org/2146733003/#ps40001
(title: "fix nit")

[commit-bot: I haz the power, 2016-07-14 02:09:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 05:11:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-14 05:12:01]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 05:13:25]

Description was changed from

==========
Remove USE_OZONE in video files

Currently all chromebooks have USE_V4L2_CODEC use flag.
We should use this instead of depending USE_OZONE to enable V4L2
devices.

BUG=627480
TEST=vea unittest pass, apprtc use hw encode/decode
==========

to

==========
Remove USE_OZONE in video files

Currently all chromebooks have USE_V4L2_CODEC use flag.
We should use this instead of depending USE_OZONE to enable V4L2
devices.

BUG=627480
TEST=vea unittest pass, apprtc use hw encode/decode

Committed: https://crrev.com/5580c3ab2104c612abf89283d76239e5c26ef672
Cr-Commit-Position: refs/heads/master@{#405436}
==========

[commit-bot: I haz the power, 2016-07-14 05:13:26]

Patchset 3 (id:??) landed as
https://crrev.com/5580c3ab2104c612abf89283d76239e5c26ef672
Cr-Commit-Position: refs/heads/master@{#405436}