Sample 1% url whitelisted PPAPI downloads to ping safe browsing server

chrome/browser/file_select_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/file_select_helper.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/files/file_enumerator.h"
 #include "base/files/file_util.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/worker_pool.h"
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/platform_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/chrome_select_file_policy.h"
+#include "chrome/common/pref_names.h"
 #include "chrome/grit/generated_resources.h"
+#include "components/prefs/pref_service.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/storage_partition.h"
@@ skipping 483 matching lines @@
       for (const auto& extension_in_list : extensions_list) {
         base::FilePath::StringType extension =
             default_file_path.ReplaceExtension(extension_in_list)
                 .FinalExtension();
         alternate_extensions.push_back(extension);
       }
     }
   }
 
   GURL requestor_url = params->requestor;
+  content::BrowserContext* browser_context = web_contents_->GetBrowserContext();
+  bool is_incognito = browser_context && browser_context->IsOffTheRecord();
+  Profile* profile = Profile::FromBrowserContext(browser_context);
+  bool is_extended_reporting =
+      profile &&
+      profile->GetPrefs()->GetBoolean(
+          prefs::kSafeBrowsingExtendedReportingEnabled);
   sb_service->download_protection_service()->CheckPPAPIDownloadRequest(
       requestor_url, default_file_path, alternate_extensions,
+      is_extended_reporting, is_incognito,

[asanka, 2016/07/14 16:48:15]

Since CheckPPAPIDownloadRequest's behavior changes depending on the type of
profile and profile preferences, shall we pass the Profile into
CheckPPAPIDownloadRequest() instead? That way FileSelectHelper doesn't need to
determine whether extended reporting is enabled. The latter should be a part of
the SafeBrowsing logic and not something that callers should be concerned with.

[Jialiu Lin, 2016/07/14 20:28:35]

Yep, passing the profile is much better. Done.

       base::Bind(&InterpretSafeBrowsingVerdict,
                  base::Bind(&FileSelectHelper::ProceedWithSafeBrowsingVerdict,
                             this, default_file_path, base::Passed(&params))));
 }
 
 void FileSelectHelper::ProceedWithSafeBrowsingVerdict(
     const base::FilePath& default_file_path,
     std::unique_ptr<content::FileChooserParams> params,
     bool allowed_by_safe_browsing) {
   if (!allowed_by_safe_browsing) {
@@ skipping 136 matching lines @@
 
 // static
 base::FilePath FileSelectHelper::GetSanitizedFileName(
     const base::FilePath& suggested_filename) {
   if (suggested_filename.empty())
     return base::FilePath();
   return net::GenerateFileName(
       GURL(), std::string(), std::string(), suggested_filename.AsUTF8Unsafe(),
       std::string(), l10n_util::GetStringUTF8(IDS_DEFAULT_DOWNLOAD_FILENAME));
 }