Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2146683002: mojo: Fix warning (treated as error) on Windows perf bots (Closed)

Created:
4 years, 5 months ago by Fady Samuel
Modified:
4 years, 5 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo: Fix warning (treated as error) on Windows perf bots BUG=627311 Committed: https://crrev.com/36e092e1f652b5a06a2042e274677ddfa21784ff Cr-Commit-Position: refs/heads/master@{#404911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M mojo/public/cpp/bindings/lib/validation_context.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/validation_context.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
Fady Samuel
4 years, 5 months ago (2016-07-12 19:52:16 UTC) #4
Fady Samuel
4 years, 5 months ago (2016-07-12 19:52:18 UTC) #5
yzshen1
lgtm
4 years, 5 months ago (2016-07-12 20:00:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146683002/1
4 years, 5 months ago (2016-07-12 20:09:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191974)
4 years, 5 months ago (2016-07-13 00:30:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146683002/1
4 years, 5 months ago (2016-07-13 00:57:27 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 02:26:37 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 02:27:39 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 02:29:53 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/36e092e1f652b5a06a2042e274677ddfa21784ff
Cr-Commit-Position: refs/heads/master@{#404911}

Powered by Google App Engine
This is Rietveld 408576698