Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: chrome/browser/chrome_web_usb_browser_client_unittest.cc

Issue 2146663002: Move //components/webusb/ to //chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix variable names Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chrome_webusb_browser_client.h" 5 #include "chrome/browser/chrome_web_usb_browser_client.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
11 #include "base/strings/utf_string_conversions.h" 11 #include "base/strings/utf_string_conversions.h"
12 #include "components/webusb/webusb_detector.h" 12 #include "chrome/browser/usb/web_usb_detector.h"
13 #include "device/core/mock_device_client.h" 13 #include "device/core/mock_device_client.h"
14 #include "device/usb/mock_usb_device.h" 14 #include "device/usb/mock_usb_device.h"
15 #include "device/usb/mock_usb_service.h" 15 #include "device/usb/mock_usb_service.h"
16 #include "device/usb/usb_device.h" 16 #include "device/usb/usb_device.h"
17 #include "device/usb/usb_service.h" 17 #include "device/usb/usb_service.h"
18 #include "testing/gtest/include/gtest/gtest.h" 18 #include "testing/gtest/include/gtest/gtest.h"
19 #include "ui/message_center/message_center.h" 19 #include "ui/message_center/message_center.h"
20 #include "ui/message_center/notification.h" 20 #include "ui/message_center/notification.h"
21 #include "ui/message_center/notification_delegate.h" 21 #include "ui/message_center/notification_delegate.h"
22 #include "url/gurl.h" 22 #include "url/gurl.h"
(...skipping 17 matching lines...) Expand all
40 ChromeWebUsbBrowserClientTest() {} 40 ChromeWebUsbBrowserClientTest() {}
41 41
42 ~ChromeWebUsbBrowserClientTest() override = default; 42 ~ChromeWebUsbBrowserClientTest() override = default;
43 43
44 void SetUp() override { message_center::MessageCenter::Initialize(); } 44 void SetUp() override { message_center::MessageCenter::Initialize(); }
45 45
46 void TearDown() override { message_center::MessageCenter::Shutdown(); } 46 void TearDown() override { message_center::MessageCenter::Shutdown(); }
47 47
48 protected: 48 protected:
49 device::MockDeviceClient device_client_; 49 device::MockDeviceClient device_client_;
50 ChromeWebUsbBrowserClient chrome_webusb_browser_client_; 50 ChromeWebUsbBrowserClient chrome_web_usb_browser_client_;
51 51
52 private: 52 private:
53 DISALLOW_COPY_AND_ASSIGN(ChromeWebUsbBrowserClientTest); 53 DISALLOW_COPY_AND_ASSIGN(ChromeWebUsbBrowserClientTest);
54 }; 54 };
55 55
56 TEST_F(ChromeWebUsbBrowserClientTest, UsbDeviceAddedAndRemoved) { 56 TEST_F(ChromeWebUsbBrowserClientTest, UsbDeviceAddedAndRemoved) {
57 GURL landing_page(kLandingPage_1); 57 GURL landing_page(kLandingPage_1);
58 scoped_refptr<device::MockUsbDevice> device(new device::MockUsbDevice( 58 scoped_refptr<device::MockUsbDevice> device(new device::MockUsbDevice(
59 0, 1, "Google", kProductName_1, "002", landing_page)); 59 0, 1, "Google", kProductName_1, "002", landing_page));
60 std::string guid = device->guid(); 60 std::string guid = device->guid();
61 61
62 webusb::WebUsbDetector webusb_detector(&chrome_webusb_browser_client_); 62 WebUsbDetector web_usb_detector(&chrome_web_usb_browser_client_);
63 63
64 device_client_.usb_service()->AddDevice(device); 64 device_client_.usb_service()->AddDevice(device);
65 65
66 message_center::MessageCenter* message_center = 66 message_center::MessageCenter* message_center =
67 message_center::MessageCenter::Get(); 67 message_center::MessageCenter::Get();
68 ASSERT_TRUE(message_center != nullptr); 68 ASSERT_TRUE(message_center != nullptr);
69 69
70 message_center::Notification* notification = 70 message_center::Notification* notification =
71 message_center->FindVisibleNotificationById(guid); 71 message_center->FindVisibleNotificationById(guid);
72 ASSERT_TRUE(notification != nullptr); 72 ASSERT_TRUE(notification != nullptr);
(...skipping 16 matching lines...) Expand all
89 } 89 }
90 90
91 TEST_F(ChromeWebUsbBrowserClientTest, 91 TEST_F(ChromeWebUsbBrowserClientTest,
92 UsbDeviceWithoutProductNameAddedAndRemoved) { 92 UsbDeviceWithoutProductNameAddedAndRemoved) {
93 std::string product_name = ""; 93 std::string product_name = "";
94 GURL landing_page(kLandingPage_1); 94 GURL landing_page(kLandingPage_1);
95 scoped_refptr<device::MockUsbDevice> device(new device::MockUsbDevice( 95 scoped_refptr<device::MockUsbDevice> device(new device::MockUsbDevice(
96 0, 1, "Google", product_name, "002", landing_page)); 96 0, 1, "Google", product_name, "002", landing_page));
97 std::string guid = device->guid(); 97 std::string guid = device->guid();
98 98
99 webusb::WebUsbDetector webusb_detector(&chrome_webusb_browser_client_); 99 WebUsbDetector web_usb_detector(&chrome_web_usb_browser_client_);
100 100
101 device_client_.usb_service()->AddDevice(device); 101 device_client_.usb_service()->AddDevice(device);
102 102
103 message_center::MessageCenter* message_center = 103 message_center::MessageCenter* message_center =
104 message_center::MessageCenter::Get(); 104 message_center::MessageCenter::Get();
105 ASSERT_TRUE(message_center != nullptr); 105 ASSERT_TRUE(message_center != nullptr);
106 106
107 // for device without product name, no notification is generated 107 // for device without product name, no notification is generated
108 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid)); 108 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid));
109 109
110 device_client_.usb_service()->RemoveDevice(device); 110 device_client_.usb_service()->RemoveDevice(device);
111 111
112 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid)); 112 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid));
113 } 113 }
114 114
115 TEST_F(ChromeWebUsbBrowserClientTest, 115 TEST_F(ChromeWebUsbBrowserClientTest,
116 UsbDeviceWithoutLandingPageAddedAndRemoved) { 116 UsbDeviceWithoutLandingPageAddedAndRemoved) {
117 GURL landing_page(""); 117 GURL landing_page("");
118 scoped_refptr<device::MockUsbDevice> device(new device::MockUsbDevice( 118 scoped_refptr<device::MockUsbDevice> device(new device::MockUsbDevice(
119 0, 1, "Google", kProductName_1, "002", landing_page)); 119 0, 1, "Google", kProductName_1, "002", landing_page));
120 std::string guid = device->guid(); 120 std::string guid = device->guid();
121 121
122 webusb::WebUsbDetector webusb_detector(&chrome_webusb_browser_client_); 122 WebUsbDetector web_usb_detector(&chrome_web_usb_browser_client_);
123 123
124 device_client_.usb_service()->AddDevice(device); 124 device_client_.usb_service()->AddDevice(device);
125 125
126 message_center::MessageCenter* message_center = 126 message_center::MessageCenter* message_center =
127 message_center::MessageCenter::Get(); 127 message_center::MessageCenter::Get();
128 ASSERT_TRUE(message_center != nullptr); 128 ASSERT_TRUE(message_center != nullptr);
129 129
130 // for device without landing page, no notification is generated 130 // for device without landing page, no notification is generated
131 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid)); 131 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid));
132 132
133 device_client_.usb_service()->RemoveDevice(device); 133 device_client_.usb_service()->RemoveDevice(device);
134 134
135 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid)); 135 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid));
136 } 136 }
137 137
138 TEST_F(ChromeWebUsbBrowserClientTest, UsbDeviceWasThereBeforeAndThenRemoved) { 138 TEST_F(ChromeWebUsbBrowserClientTest, UsbDeviceWasThereBeforeAndThenRemoved) {
139 GURL landing_page(kLandingPage_1); 139 GURL landing_page(kLandingPage_1);
140 scoped_refptr<device::MockUsbDevice> device(new device::MockUsbDevice( 140 scoped_refptr<device::MockUsbDevice> device(new device::MockUsbDevice(
141 0, 1, "Google", kProductName_1, "002", landing_page)); 141 0, 1, "Google", kProductName_1, "002", landing_page));
142 std::string guid = device->guid(); 142 std::string guid = device->guid();
143 143
144 webusb::WebUsbDetector webusb_detector(&chrome_webusb_browser_client_); 144 WebUsbDetector web_usb_detector(&chrome_web_usb_browser_client_);
145 145
146 message_center::MessageCenter* message_center = 146 message_center::MessageCenter* message_center =
147 message_center::MessageCenter::Get(); 147 message_center::MessageCenter::Get();
148 ASSERT_TRUE(message_center != nullptr); 148 ASSERT_TRUE(message_center != nullptr);
149 149
150 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid)); 150 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid));
151 151
152 device_client_.usb_service()->RemoveDevice(device); 152 device_client_.usb_service()->RemoveDevice(device);
153 153
154 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid)); 154 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid));
(...skipping 11 matching lines...) Expand all
166 scoped_refptr<device::MockUsbDevice> device_2(new device::MockUsbDevice( 166 scoped_refptr<device::MockUsbDevice> device_2(new device::MockUsbDevice(
167 3, 4, "Google", kProductName_2, "005", landing_page_2)); 167 3, 4, "Google", kProductName_2, "005", landing_page_2));
168 std::string guid_2 = device_2->guid(); 168 std::string guid_2 = device_2->guid();
169 169
170 base::string16 product_name_3 = base::UTF8ToUTF16(kProductName_3); 170 base::string16 product_name_3 = base::UTF8ToUTF16(kProductName_3);
171 GURL landing_page_3(kLandingPage_3); 171 GURL landing_page_3(kLandingPage_3);
172 scoped_refptr<device::MockUsbDevice> device_3(new device::MockUsbDevice( 172 scoped_refptr<device::MockUsbDevice> device_3(new device::MockUsbDevice(
173 6, 7, "Google", kProductName_3, "008", landing_page_3)); 173 6, 7, "Google", kProductName_3, "008", landing_page_3));
174 std::string guid_3 = device_3->guid(); 174 std::string guid_3 = device_3->guid();
175 175
176 webusb::WebUsbDetector webusb_detector(&chrome_webusb_browser_client_); 176 WebUsbDetector web_usb_detector(&chrome_web_usb_browser_client_);
177 177
178 device_client_.usb_service()->AddDevice(device_1); 178 device_client_.usb_service()->AddDevice(device_1);
179 device_client_.usb_service()->AddDevice(device_2); 179 device_client_.usb_service()->AddDevice(device_2);
180 device_client_.usb_service()->AddDevice(device_3); 180 device_client_.usb_service()->AddDevice(device_3);
181 181
182 message_center::MessageCenter* message_center = 182 message_center::MessageCenter* message_center =
183 message_center::MessageCenter::Get(); 183 message_center::MessageCenter::Get();
184 ASSERT_TRUE(message_center != nullptr); 184 ASSERT_TRUE(message_center != nullptr);
185 185
186 message_center::Notification* notification_1 = 186 message_center::Notification* notification_1 =
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 device_client_.usb_service()->RemoveDevice(device_1); 220 device_client_.usb_service()->RemoveDevice(device_1);
221 device_client_.usb_service()->RemoveDevice(device_2); 221 device_client_.usb_service()->RemoveDevice(device_2);
222 device_client_.usb_service()->RemoveDevice(device_3); 222 device_client_.usb_service()->RemoveDevice(device_3);
223 223
224 // devices are removed, so notifications should be removed from the 224 // devices are removed, so notifications should be removed from the
225 // message_center too 225 // message_center too
226 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid_1)); 226 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid_1));
227 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid_2)); 227 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid_2));
228 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid_3)); 228 EXPECT_EQ(nullptr, message_center->FindVisibleNotificationById(guid_3));
229 } 229 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698