Move //components/webusb/ to //chrome/browser/

Move //components/webusb/ to //chrome/browser/

Since webusb is only used by //chrome/browser, this
CL moved the directory from //components to //chrome/browser.

The context is: https://bugs.chromium.org/p/chromium/issues/detail?id=624590

Since there is already a directory: //chrome/browser/usb, source files from
webusb directory is moved there. And it also changes webusb to web_usb to
be consistent with the filenames at //chrome/browser/usb.

BUG=627510
Committed: https://crrev.com/1da12030f6c17ef7d05218d0e812d4bd0c575c75
Cr-Commit-Position: refs/heads/master@{#405808}

[juncai, 2016-07-12 19:58:09]

juncai@chromium.org changed reviewers:
+ jam@chromium.org

[juncai, 2016-07-12 19:58:10]

Please take a look.

[jam, 2016-07-12 21:08:45]

lgtm

https://codereview.chromium.org/2146663002/diff/20001/chrome/browser/chrome_w...
File chrome/browser/chrome_web_usb_browser_client.h (right):

https://codereview.chromium.org/2146663002/diff/20001/chrome/browser/chrome_w...
chrome/browser/chrome_web_usb_browser_client.h:15: class
ChromeWebUsbBrowserClient : public WebUsbBrowserClient {
do we still need this abstraction? i see it's used in a unit test.

If we don't and the test can be written without it, please remove it. If we do
need it, please update the comment.

[Reilly Grant (use Gerrit), 2016-07-12 21:23:09]

On 2016/07/12 at 21:08:45, jam wrote:
> lgtm
> 
>
https://codereview.chromium.org/2146663002/diff/20001/chrome/browser/chrome_w...
> File chrome/browser/chrome_web_usb_browser_client.h (right):
> 
>
https://codereview.chromium.org/2146663002/diff/20001/chrome/browser/chrome_w...
> chrome/browser/chrome_web_usb_browser_client.h:15: class
ChromeWebUsbBrowserClient : public WebUsbBrowserClient {
> do we still need this abstraction? i see it's used in a unit test.
> 
> If we don't and the test can be written without it, please remove it. If we do
need it, please update the comment.

We should be able to test it end-to-end without the client interface.

[juncai, 2016-07-12 22:28:34]

https://codereview.chromium.org/2146663002/diff/20001/chrome/browser/chrome_w...
File chrome/browser/chrome_web_usb_browser_client.h (right):

https://codereview.chromium.org/2146663002/diff/20001/chrome/browser/chrome_w...
chrome/browser/chrome_web_usb_browser_client.h:15: class
ChromeWebUsbBrowserClient : public WebUsbBrowserClient {
On 2016/07/12 21:08:45, jam wrote:
> do we still need this abstraction? i see it's used in a unit test.
> 
> If we don't and the test can be written without it, please remove it. If we do
> need it, please update the comment.

Removed the abstraction. 

Done.

[jam, 2016-07-13 16:54:58]

https://codereview.chromium.org/2146663002/diff/20001/chrome/browser/chrome_w...
File chrome/browser/chrome_web_usb_browser_client.h (right):

https://codereview.chromium.org/2146663002/diff/20001/chrome/browser/chrome_w...
chrome/browser/chrome_web_usb_browser_client.h:15: class
ChromeWebUsbBrowserClient : public WebUsbBrowserClient {
On 2016/07/12 22:28:34, juncai wrote:
> On 2016/07/12 21:08:45, jam wrote:
> > do we still need this abstraction? i see it's used in a unit test.
> > 
> > If we don't and the test can be written without it, please remove it. If we
do
> > need it, please update the comment.
> 
> Removed the abstraction. 
> 
> Done.

The interface is gone, but we still have WebUsbBrowserClient class. Can we
remove the latter by merging that code into WebUsbDetector (with appropriate
hooks for the unittest)?

[juncai, 2016-07-13 22:54:09]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 22:54:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-07-13 23:05:56]

On 2016/07/13 16:54:58, jam wrote:
>
https://codereview.chromium.org/2146663002/diff/20001/chrome/browser/chrome_w...
> File chrome/browser/chrome_web_usb_browser_client.h (right):
> 
>
https://codereview.chromium.org/2146663002/diff/20001/chrome/browser/chrome_w...
> chrome/browser/chrome_web_usb_browser_client.h:15: class
> ChromeWebUsbBrowserClient : public WebUsbBrowserClient {
> On 2016/07/12 22:28:34, juncai wrote:
> > On 2016/07/12 21:08:45, jam wrote:
> > > do we still need this abstraction? i see it's used in a unit test.
> > > 
> > > If we don't and the test can be written without it, please remove it. If
we
> do
> > > need it, please update the comment.
> > 
> > Removed the abstraction. 
> > 
> > Done.
> 
> The interface is gone, but we still have WebUsbBrowserClient class. Can we
> remove the latter by merging that code into WebUsbDetector (with appropriate
> hooks for the unittest)?

Good point. WebUsbBrowserClient class has been merged to WebUsbDetector.

[commit-bot: I haz the power, 2016-07-14 01:31:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 01:31:10]

Dry run: This issue passed the CQ dry run.

[jam, 2016-07-14 20:09:38]

On 2016/07/13 23:05:56, juncai wrote:
> On 2016/07/13 16:54:58, jam wrote:
> >
>
https://codereview.chromium.org/2146663002/diff/20001/chrome/browser/chrome_w...
> > File chrome/browser/chrome_web_usb_browser_client.h (right):
> > 
> >
>
https://codereview.chromium.org/2146663002/diff/20001/chrome/browser/chrome_w...
> > chrome/browser/chrome_web_usb_browser_client.h:15: class
> > ChromeWebUsbBrowserClient : public WebUsbBrowserClient {
> > On 2016/07/12 22:28:34, juncai wrote:
> > > On 2016/07/12 21:08:45, jam wrote:
> > > > do we still need this abstraction? i see it's used in a unit test.
> > > > 
> > > > If we don't and the test can be written without it, please remove it. If
> we
> > do
> > > > need it, please update the comment.
> > > 
> > > Removed the abstraction. 
> > > 
> > > Done.
> > 
> > The interface is gone, but we still have WebUsbBrowserClient class. Can we
> > remove the latter by merging that code into WebUsbDetector (with appropriate
> > hooks for the unittest)?
> 
> Good point. WebUsbBrowserClient class has been merged to WebUsbDetector.

still lgtm, thanks!

[juncai, 2016-07-15 17:50:08]

https://codereview.chromium.org/2146663002/diff/20001/chrome/browser/chrome_w...
File chrome/browser/chrome_web_usb_browser_client.h (right):

https://codereview.chromium.org/2146663002/diff/20001/chrome/browser/chrome_w...
chrome/browser/chrome_web_usb_browser_client.h:15: class
ChromeWebUsbBrowserClient : public WebUsbBrowserClient {
On 2016/07/13 16:54:57, jam wrote:
> On 2016/07/12 22:28:34, juncai wrote:
> > On 2016/07/12 21:08:45, jam wrote:
> > > do we still need this abstraction? i see it's used in a unit test.
> > > 
> > > If we don't and the test can be written without it, please remove it. If
we
> do
> > > need it, please update the comment.
> > 
> > Removed the abstraction. 
> > 
> > Done.
> 
> The interface is gone, but we still have WebUsbBrowserClient class. Can we
> remove the latter by merging that code into WebUsbDetector (with appropriate
> hooks for the unittest)?

Done.

[juncai, 2016-07-15 17:50:14]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2016-07-15 17:51:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 19:10:38]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-15 19:10:50]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 19:13:57]

Description was changed from

==========
Move //components/webusb/ to //chrome/browser/

Since webusb is only used by //chrome/browser, this
CL moved the directory from //components to //chrome/browser.

The context is: https://bugs.chromium.org/p/chromium/issues/detail?id=624590

Since there is already a directory: //chrome/browser/usb, source files from
webusb directory is moved there. And it also changes webusb to web_usb to
be consistent with the filenames at //chrome/browser/usb.

BUG=627510
==========

to

==========
Move //components/webusb/ to //chrome/browser/

Since webusb is only used by //chrome/browser, this
CL moved the directory from //components to //chrome/browser.

The context is: https://bugs.chromium.org/p/chromium/issues/detail?id=624590

Since there is already a directory: //chrome/browser/usb, source files from
webusb directory is moved there. And it also changes webusb to web_usb to
be consistent with the filenames at //chrome/browser/usb.

BUG=627510

Committed: https://crrev.com/1da12030f6c17ef7d05218d0e812d4bd0c575c75
Cr-Commit-Position: refs/heads/master@{#405808}
==========

[commit-bot: I haz the power, 2016-07-15 19:14:00]

Patchset 6 (id:??) landed as
https://crrev.com/1da12030f6c17ef7d05218d0e812d4bd0c575c75
Cr-Commit-Position: refs/heads/master@{#405808}