Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 214663008: Cast: Clarify the unit of bitrate (Closed)

Created:
6 years, 9 months ago by Alpha Left Google
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, feature-media-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Cast: Clarify the unit of bitrate This change is to clarify the unit used in cast.streaming APIs for bitrate. It should be in kilobits per second. And the unit conversion should be done just before converting to VideoSenderConfig and AudioSenderConfig which use bits per second as unit. This will improve the video quality for existing extensions which use kilobits per second. BUG=354267 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M chrome/common/extensions/api/cast_streaming_rtp_stream.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/media/cast_rtp_stream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/media/cast_rtp_stream.cc View 5 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Alpha Left Google
6 years, 9 months ago (2014-03-27 19:33:28 UTC) #1
not at google - send to devlin
lgtm
6 years, 9 months ago (2014-03-27 19:39:43 UTC) #2
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 9 months ago (2014-03-27 20:37:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/214663008/1
6 years, 9 months ago (2014-03-27 20:41:17 UTC) #4
hshi1
The CQ bit was unchecked by hshi@chromium.org
6 years, 9 months ago (2014-03-28 21:15:26 UTC) #5
hshi1
The CQ bit was checked by hshi@chromium.org
6 years, 9 months ago (2014-03-28 21:15:36 UTC) #6
cmp
The CQ bit was unchecked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 17:00:09 UTC) #7
cmp
The CQ bit was checked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 17:02:20 UTC) #8
cmp
The CQ bit was unchecked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 17:03:41 UTC) #9
cmp
The CQ bit was checked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 17:07:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/214663008/1
6 years, 8 months ago (2014-03-30 17:07:36 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-03-30 17:10:01 UTC) #12
Message was sent while issue was closed.
Change committed as 260438

Powered by Google App Engine
This is Rietveld 408576698