Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4414)

Unified Diff: Source/devtools/front_end/HeapSnapshotView.js

Issue 214663005: [DevTools] Add preferred size to WebInspector.View. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Constraints Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/HeapSnapshotView.js
diff --git a/Source/devtools/front_end/HeapSnapshotView.js b/Source/devtools/front_end/HeapSnapshotView.js
index 0ec075cd68299f48d08e5a55f9fadf8fed228dfd..7aeeec8724033fd4ab3bb680a1b53e975739f223 100644
--- a/Source/devtools/front_end/HeapSnapshotView.js
+++ b/Source/devtools/front_end/HeapSnapshotView.js
@@ -51,7 +51,7 @@ WebInspector.HeapSnapshotView = function(profile)
this._splitView.show(this.element);
this._containmentView = new WebInspector.VBox();
- this._containmentView.setMinimumSize(50, 25);
+ this._containmentView.setConstraints(50, 25);
this._containmentDataGrid = new WebInspector.HeapSnapshotContainmentDataGrid();
this._containmentDataGrid.show(this._containmentView.element);
this._containmentDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._selectionChanged, this);
@@ -59,28 +59,28 @@ WebInspector.HeapSnapshotView = function(profile)
this._statisticsView = new WebInspector.HeapSnapshotStatisticsView();
this._constructorsView = new WebInspector.VBox();
- this._constructorsView.setMinimumSize(50, 25);
+ this._constructorsView.setConstraints(50, 25);
this._constructorsDataGrid = new WebInspector.HeapSnapshotConstructorsDataGrid();
this._constructorsDataGrid.show(this._constructorsView.element);
this._constructorsDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._selectionChanged, this);
this._diffView = new WebInspector.VBox();
- this._diffView.setMinimumSize(50, 25);
+ this._diffView.setConstraints(50, 25);
this._diffDataGrid = new WebInspector.HeapSnapshotDiffDataGrid();
this._diffDataGrid.show(this._diffView.element);
this._diffDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._selectionChanged, this);
this._dominatorView = new WebInspector.VBox();
- this._dominatorView.setMinimumSize(50, 25);
+ this._dominatorView.setConstraints(50, 25);
this._dominatorDataGrid = new WebInspector.HeapSnapshotDominatorsDataGrid();
this._dominatorDataGrid.show(this._dominatorView.element);
this._dominatorDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._selectionChanged, this);
if (WebInspector.experimentsSettings.allocationProfiler.isEnabled() && profile.profileType() === WebInspector.ProfileTypeRegistry.instance.trackingHeapSnapshotProfileType) {
this._allocationView = new WebInspector.VBox();
- this._allocationView.setMinimumSize(50, 25);
+ this._allocationView.setConstraints(50, 25);
this._allocationDataGrid = new WebInspector.AllocationDataGrid();
this._allocationDataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._onSelectAllocationNode, this);
this._allocationDataGrid.show(this._allocationView.element);
@@ -94,7 +94,7 @@ WebInspector.HeapSnapshotView = function(profile)
this._splitView.installResizer(this._retainmentViewHeader);
this._retainmentView = new WebInspector.VBox();
- this._retainmentView.setMinimumSize(50, 21);
+ this._retainmentView.setConstraints(50, 21);
this._retainmentView.element.classList.add("retaining-paths-view");
this._retainmentView.element.appendChild(this._retainmentViewHeader);
this._retainmentDataGrid = new WebInspector.HeapSnapshotRetainmentDataGrid();
@@ -2140,7 +2140,7 @@ WebInspector.HeapTrackingOverviewGrid.OverviewCalculator.prototype = {
WebInspector.HeapSnapshotStatisticsView = function()
{
WebInspector.VBox.call(this);
- this.setMinimumSize(50, 25);
+ this.setConstraints(50, 25);
this._pieChart = new WebInspector.PieChart();
this._pieChart.setSize(150);
this.element.appendChild(this._pieChart.element);

Powered by Google App Engine
This is Rietveld 408576698