[DevTools] Add preferred size to WebInspector.View.

Source/devtools/front_end/DOMExtension.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 180 matching lines @@
         var nodeToRemove = node;
         node = node.nextSibling;
         nodeToRemove.remove();
     }
 }
 
 /**
  * @constructor
  * @param {number} width
  * @param {number} height
+ * @param {number=} preferredWidth
+ * @param {number=} preferredHeight
  */
-function Size(width, height)
+function Size(width, height, preferredWidth, preferredHeight)

[vsevik, 2014/03/28 16:13:26]

I don't think we should merge them, it's confusing.

[dgozman, 2014/03/28 18:05:02]

Created a Constraints object.

 {
     this.width = width;
     this.height = height;
+    this.preferredWidth = preferredWidth;
+    if (typeof preferredWidth === "undefined")
+        this.preferredWidth = width;
+    this.preferredHeight = preferredHeight;
+    if (typeof preferredHeight === "undefined")
+        this.preferredHeight = height;
 }
 
 /**
  * @param {?Size} size
  * @return {boolean}
  */
 Size.prototype.isEqual = function(size)
 {
-    return !!size && this.width === size.width && this.height === size.height;
+    return !!size && this.width === size.width && this.height === size.height && this.preferredWidth == size.preferredWidth && this.preferredHeight == size.preferredHeight;
 };
 
 /**
+ * @return {!Size}
+ */
+Size.prototype.widthToMax = function(size)

[vsevik, 2014/03/28 16:13:26]

Size.prototype.constrainWidth = function(minWidth, maxWidth)

[dgozman, 2014/03/28 18:05:02]

But I need a Size with width to be a maximum of two.

[vsevik, 2014/03/28 18:24:50]

size.widthToMax(new Size(w, 0)) would be equivalent to size.constrainWidth(w)

+{
+    return new Size(Math.max(this.width, size.width), this.height, Math.max(this.preferredWidth, size.preferredWidth), this.preferredHeight);
+};
+
+/**
+ * @return {!Size}
+ */
+Size.prototype.addWidth = function(size)

[vsevik, 2014/03/28 16:13:26]

Size.prototype.addWidth = function(width)

+{
+    return new Size(this.width + size.width, this.height, this.preferredWidth + size.preferredWidth, this.preferredHeight);
+};
+
+/**
+ * @return {!Size}
+ */
+Size.prototype.heightToMax = function(size)
+{
+    return new Size(this.width, Math.max(this.height, size.height), this.preferredWidth, Math.max(this.preferredHeight, size.preferredHeight));
+};
+
+/**
+ * @return {!Size}
+ */
+Size.prototype.addHeight = function(size)
+{
+    return new Size(this.width, this.height + size.height, this.preferredWidth, this.preferredHeight + size.preferredHeight);
+};
+
+/**
  * @param {?Element=} containerElement
  * @return {!Size}
  */
 Element.prototype.measurePreferredSize = function(containerElement)
 {
     containerElement = containerElement || document.body;
     containerElement.appendChild(this);
     this.positionAt(0, 0);
     var result = new Size(this.offsetWidth, this.offsetHeight);
     this.positionAt(undefined, undefined);
@@ skipping 366 matching lines @@
  */
 function isEnterKey(event) {
     // Check if in IME.
     return event.keyCode !== 229 && event.keyIdentifier === "Enter";
 }
 
 function consumeEvent(e)
 {
     e.consume();
 }