[DevTools] Add preferred size to WebInspector.View.

[DevTools] Add preferred size to WebInspector.View.

We now try to satisfy preferred size, but when it's impossible
ensure minimum size at least.

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170459

[dgozman, 2014-03-27 14:43:59]

Take a look please.

[vsevik, 2014-03-28 16:13:25]

https://chromiumcodereview.appspot.com/214663005/diff/20001/Source/devtools/f...
File Source/devtools/front_end/DOMExtension.js (right):

https://chromiumcodereview.appspot.com/214663005/diff/20001/Source/devtools/f...
Source/devtools/front_end/DOMExtension.js:204: function Size(width, height,
preferredWidth, preferredHeight)
I don't think we should merge them, it's confusing.

https://chromiumcodereview.appspot.com/214663005/diff/20001/Source/devtools/f...
Source/devtools/front_end/DOMExtension.js:228: Size.prototype.widthToMax =
function(size)
Size.prototype.constrainWidth = function(minWidth, maxWidth)

https://chromiumcodereview.appspot.com/214663005/diff/20001/Source/devtools/f...
Source/devtools/front_end/DOMExtension.js:236: Size.prototype.addWidth =
function(size)
Size.prototype.addWidth = function(width)

https://chromiumcodereview.appspot.com/214663005/diff/20001/Source/devtools/f...
File Source/devtools/front_end/SourcesView.js (right):

https://chromiumcodereview.appspot.com/214663005/diff/20001/Source/devtools/f...
Source/devtools/front_end/SourcesView.js:19: this.setMinimumSize(50, 25, 150,
150);
150, 100

Should be enough for now.

https://chromiumcodereview.appspot.com/214663005/diff/20001/Source/devtools/f...
File Source/devtools/front_end/SplitView.js (right):

https://chromiumcodereview.appspot.com/214663005/diff/20001/Source/devtools/f...
Source/devtools/front_end/SplitView.js:560: if (totalPreferred > 0 &&
minMainSize + minSidebarSize <= totalSize) {
How can totalPreferred > 0 be wrong?

[dgozman, 2014-03-28 18:05:02]

+pfeldman

PTAL

https://codereview.chromium.org/214663005/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/DOMExtension.js (right):

https://codereview.chromium.org/214663005/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/DOMExtension.js:204: function Size(width, height,
preferredWidth, preferredHeight)
On 2014/03/28 16:13:26, vsevik wrote:
> I don't think we should merge them, it's confusing.

Created a Constraints object.

https://codereview.chromium.org/214663005/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/DOMExtension.js:228: Size.prototype.widthToMax =
function(size)
On 2014/03/28 16:13:26, vsevik wrote:
> Size.prototype.constrainWidth = function(minWidth, maxWidth)

But I need a Size with width to be a maximum of two.

https://codereview.chromium.org/214663005/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/SourcesView.js (right):

https://codereview.chromium.org/214663005/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/SourcesView.js:19: this.setMinimumSize(50, 25, 150,
150);
On 2014/03/28 16:13:26, vsevik wrote:
> 150, 100
> 
> Should be enough for now.

Done.

https://codereview.chromium.org/214663005/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/SplitView.js (right):

https://codereview.chromium.org/214663005/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/SplitView.js:560: if (totalPreferred > 0 &&
minMainSize + minSidebarSize <= totalSize) {
On 2014/03/28 16:13:26, vsevik wrote:
> How can totalPreferred > 0 be wrong?

Done.

[vsevik, 2014-03-28 18:24:49]

https://codereview.chromium.org/214663005/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/DOMExtension.js (right):

https://codereview.chromium.org/214663005/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/DOMExtension.js:228: Size.prototype.widthToMax =
function(size)
size.widthToMax(new Size(w, 0)) would be equivalent to size.constrainWidth(w)

[pfeldman, 2014-03-31 12:10:38]

https://codereview.chromium.org/214663005/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/SplitView.js (right):

https://codereview.chromium.org/214663005/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/SplitView.js:528: var constraints =
this._sidebarView.constraints();
This logic definitely needs a test.

https://codereview.chromium.org/214663005/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/SplitView.js:606: mainConstraints =
mainConstraints.widthToMax(new Constraints(new Size(min, 0)));
Creating Constraints and Size seems like an overkill if you simply want to
enlarge mainConstraints to be > min width.

https://codereview.chromium.org/214663005/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/View.js (right):

https://codereview.chromium.org/214663005/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/View.js:533: setConstraints: function(width, height,
preferredWidth, preferredHeight)
Why not setMinimumSize and setPreferredSize? You would only have 2 usages of the
latter.

[dgozman, 2014-03-31 13:23:56]

PTAL

https://codereview.chromium.org/214663005/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/SplitView.js (right):

https://codereview.chromium.org/214663005/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/SplitView.js:528: var constraints =
this._sidebarView.constraints();
On 2014/03/31 12:10:39, pfeldman wrote:
> This logic definitely needs a test.

Done.

https://codereview.chromium.org/214663005/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/SplitView.js:606: mainConstraints =
mainConstraints.widthToMax(new Constraints(new Size(min, 0)));
On 2014/03/31 12:10:39, pfeldman wrote:
> Creating Constraints and Size seems like an overkill if you simply want to
> enlarge mainConstraints to be > min width.

Done.

https://codereview.chromium.org/214663005/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/View.js (right):

https://codereview.chromium.org/214663005/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/View.js:533: setConstraints: function(width, height,
preferredWidth, preferredHeight)
On 2014/03/31 12:10:39, pfeldman wrote:
> Why not setMinimumSize and setPreferredSize? You would only have 2 usages of
the
> latter.

There will be more preferred sizes in follow-up patches.
Also, setting preferred size without minimum size does not make a sense.

[dgozman, 2014-03-31 15:12:14]

I've split setConstraints into 2 methods. PTAL

[pfeldman, 2014-03-31 15:31:05]

lgtm

[dgozman, 2014-03-31 15:31:40]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-03-31 15:31:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgozman@chromium.org/214663005/80001

[commit-bot: I haz the power, 2014-03-31 16:37:39]

Change committed as 170459