Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: content/test/data/media/peerconnection-call.html

Issue 214663004: Add test for sending square resolution video on a PeerConnection. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/media/webrtc_browsertest.cc ('k') | content/test/data/media/webrtc_test_utilities.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/data/media/peerconnection-call.html
diff --git a/content/test/data/media/peerconnection-call.html b/content/test/data/media/peerconnection-call.html
index 29a23b8f9151bde9b034f3b21a6c4eb347144d21..3e1ac97501d16a882d5d9d5ccc9f698bcc04a9bd 100644
--- a/content/test/data/media/peerconnection-call.html
+++ b/content/test/data/media/peerconnection-call.html
@@ -53,7 +53,7 @@
var EXTERNAL_GICE_PWD = '123456789012345678901234';
setAllEventsOccuredHandler(reportTestSuccess);
-
+
phoglund_chromium 2014/03/28 12:43:34 Nit: remove
perkj_chrome 2014/03/31 08:13:32 Done.
// Test that we can setup call with an audio and video track.
function call(constraints) {
createConnections(null);
@@ -63,6 +63,23 @@
waitForVideo('remote-view-2');
}
+ // Test that we can setup call with an audio and video track and check that
+ // the video resolution is as expected.
+ function callAndExpectResolution(constraints,
+ expected_width,
+ expected_height) {
+ createConnections(null);
+ navigator.webkitGetUserMedia(constraints,
+ addStreamToBothConnectionsAndNegotiate, printGetUserMediaError);
+ waitForVideoWithResolution('remote-view-1',
+ expected_width,
+ expected_height);
+ waitForVideoWithResolution('remote-view-2',
+ expected_width,
+ expected_height);
+ }
+
+
// First calls without streams on any connections, and then adds a stream
// to peer connection 1 which gets sent to peer connection 2. We must wait
// for the first negotiation to complete before starting the second one, which
« no previous file with comments | « content/browser/media/webrtc_browsertest.cc ('k') | content/test/data/media/webrtc_test_utilities.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698