Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2146613002: Relax service protocol origin check to allow connections from localhost on any port (Closed)

Created:
4 years, 5 months ago by Cutch
Modified:
4 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Relax service protocol origin check to allow connections from localhost on any port. This is necessary because adb port forwarding will give us a different port than the port bound on the actual device. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/e6e61332d6ec7c3bd6c92fa7496282174db521a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M runtime/bin/vmservice/server.dart View 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
4 years, 5 months ago (2016-07-12 18:59:59 UTC) #4
siva
lgtm
4 years, 5 months ago (2016-07-12 20:11:04 UTC) #5
Cutch
4 years, 5 months ago (2016-07-12 20:27:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e6e61332d6ec7c3bd6c92fa7496282174db521a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698