Revert of arc: Use the new InstanceHolder for unittests

Revert of arc: Use the new InstanceHolder for unittests (patchset #4 id:60001 of https://codereview.chromium.org/2138513002/ )

Reason for revert:
Caused unit_tests failure on Linux ChromiumOS Tests (1):

ArcAppModelBuilderTest.RemoveAppCleanUpFolder

Original issue's description:
> arc: Use the new InstanceHolder for unittests
>
> Instead of having unit tests go through Mojo and jump through hoops to
> ensure that all messages have propagated to all the threads, we can use
> the new arc::ArcBridgeService::InstanceHolder<T>::SetInstance() to
> directly set the concrete fake (and optional version). This simplifies
> testing quite a bit.
>
> BUG=626695
> TEST=trybots
>
> Committed: https://crrev.com/c5fffc64c14a0464f8870bbe91df7e945f42c3ca
> Cr-Commit-Position: refs/heads/master@{#405138}

TBR=hidehiko@chromium.org,stevenjb@chromium.org,lhchavez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=626695
Committed: https://crrev.com/03b1e37434a736bbb5c764dd980787e54c93868b
Cr-Commit-Position: refs/heads/master@{#405165}

[engedy, 2016-07-13 15:50:49]

The CQ bit was checked by engedy@chromium.org

[engedy, 2016-07-13 15:50:50]

Created Revert of arc: Use the new InstanceHolder for unittests

[commit-bot: I haz the power, 2016-07-13 15:51:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Luis Héctor Chávez, 2016-07-13 15:51:58]

On 2016/07/13 15:51:17, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

This doesn't seem like the root cause, but it's better to revert while I
investigate. lgtm.

[commit-bot: I haz the power, 2016-07-13 15:52:11]

Description was changed from

==========
Revert of arc: Use the new InstanceHolder for unittests (patchset #4 id:60001 of
https://codereview.chromium.org/2138513002/ )

Reason for revert:
Caused unit_tests failure on Linux ChromiumOS Tests (1):

ArcAppModelBuilderTest.RemoveAppCleanUpFolder

Original issue's description:
> arc: Use the new InstanceHolder for unittests
> 
> Instead of having unit tests go through Mojo and jump through hoops to
> ensure that all messages have propagated to all the threads, we can use
> the new arc::ArcBridgeService::InstanceHolder<T>::SetInstance() to
> directly set the concrete fake (and optional version). This simplifies
> testing quite a bit.
> 
> BUG=626695
> TEST=trybots
> 
> Committed: https://crrev.com/c5fffc64c14a0464f8870bbe91df7e945f42c3ca
> Cr-Commit-Position: refs/heads/master@{#405138}

TBR=hidehiko@chromium.org,stevenjb@chromium.org,lhchavez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=626695
==========

to

==========
Revert of arc: Use the new InstanceHolder for unittests (patchset #4 id:60001 of
https://codereview.chromium.org/2138513002/ )

Reason for revert:
Caused unit_tests failure on Linux ChromiumOS Tests (1):

ArcAppModelBuilderTest.RemoveAppCleanUpFolder

Original issue's description:
> arc: Use the new InstanceHolder for unittests
> 
> Instead of having unit tests go through Mojo and jump through hoops to
> ensure that all messages have propagated to all the threads, we can use
> the new arc::ArcBridgeService::InstanceHolder<T>::SetInstance() to
> directly set the concrete fake (and optional version). This simplifies
> testing quite a bit.
> 
> BUG=626695
> TEST=trybots
> 
> Committed: https://crrev.com/c5fffc64c14a0464f8870bbe91df7e945f42c3ca
> Cr-Commit-Position: refs/heads/master@{#405138}

TBR=hidehiko@chromium.org,stevenjb@chromium.org,lhchavez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=626695
==========

[commit-bot: I haz the power, 2016-07-13 15:52:12]

Committed patchset #1 (id:1)

[engedy, 2016-07-13 15:52:14]

Failed run:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

Test output:

ArcAppModelBuilderTest.RemoveAppCleanUpFolder (run #1):
[ RUN      ] ArcAppModelBuilderTest.RemoveAppCleanUpFolder
Received signal 11 SEGV_MAPERR 000000000000
#0 0x0000054b1897 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7f6c007bdcb0 <unknown>
#2 0x000002c4e15b content::UtilityProcessHostImpl::GetRemoteInterfaces()
#3 0x0000051aa50d ImageDecoder::StartBatchMode()
#4 0x0000051a9ef9 ImageDecoder::DecodeImageInSandbox()
#5 0x000005524886 base::debug::TaskAnnotator::RunTask()
#6 0x0000054c8cb5 base::MessageLoop::RunTask()
#7 0x0000054c8fa8 base::MessageLoop::DeferOrRunPendingTask()
#8 0x0000054c92eb base::MessageLoop::DoWork()
#9 0x0000054caec9 base::MessagePumpLibevent::Run()
#10 0x0000054e2c4e base::RunLoop::Run()
#11 0x000001ccedfb
ArcAppModelBuilderTest_RemoveAppCleanUpFolder_Test::TestBody()
#12 0x000004cbe0e7 testing::Test::Run()
#13 0x000004cbeda3 testing::TestInfo::Run()
#14 0x000004cbf233 testing::TestCase::Run()
#15 0x000004cc6409 testing::internal::UnitTestImpl::RunAllTests()
#16 0x000004cc60ae testing::UnitTest::Run()
#17 0x000001cdf806 base::TestSuite::Run()
#18 0x000001cebb44 base::LaunchUnitTests()
#19 0x000001cda8a6 main
#20 0x7f6bfbe657ed __libc_start_main
#21 0x000000680821 <unknown>
  r8: 00007f6bf5269700  r9: 00007f6bf5269700 r10: 00007f6bf52699d0 r11:
0000000000000206
 r12: 00007fff25f9e118 r13: 0000000002c4e190 r14: 00000000097a2e70 r15:
00000000097a2e08
  di: 0000000000000000  si: 0000000000000000  bp: 0000000000000000  bx:
000000000aef2201
  dx: 00001caf0ae9fdc0  ax: 00001caf0afa1100  cx: 0000000000000003  sp:
00007fff25f9e0d8
  ip: 0000000002c4e15b efl: 0000000000010202 cgf: 0000000000000033 erf:
0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]

[commit-bot: I haz the power, 2016-07-13 15:54:25]

Description was changed from

==========
Revert of arc: Use the new InstanceHolder for unittests (patchset #4 id:60001 of
https://codereview.chromium.org/2138513002/ )

Reason for revert:
Caused unit_tests failure on Linux ChromiumOS Tests (1):

ArcAppModelBuilderTest.RemoveAppCleanUpFolder

Original issue's description:
> arc: Use the new InstanceHolder for unittests
> 
> Instead of having unit tests go through Mojo and jump through hoops to
> ensure that all messages have propagated to all the threads, we can use
> the new arc::ArcBridgeService::InstanceHolder<T>::SetInstance() to
> directly set the concrete fake (and optional version). This simplifies
> testing quite a bit.
> 
> BUG=626695
> TEST=trybots
> 
> Committed: https://crrev.com/c5fffc64c14a0464f8870bbe91df7e945f42c3ca
> Cr-Commit-Position: refs/heads/master@{#405138}

TBR=hidehiko@chromium.org,stevenjb@chromium.org,lhchavez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=626695
==========

to

==========
Revert of arc: Use the new InstanceHolder for unittests (patchset #4 id:60001 of
https://codereview.chromium.org/2138513002/ )

Reason for revert:
Caused unit_tests failure on Linux ChromiumOS Tests (1):

ArcAppModelBuilderTest.RemoveAppCleanUpFolder

Original issue's description:
> arc: Use the new InstanceHolder for unittests
>
> Instead of having unit tests go through Mojo and jump through hoops to
> ensure that all messages have propagated to all the threads, we can use
> the new arc::ArcBridgeService::InstanceHolder<T>::SetInstance() to
> directly set the concrete fake (and optional version). This simplifies
> testing quite a bit.
>
> BUG=626695
> TEST=trybots
>
> Committed: https://crrev.com/c5fffc64c14a0464f8870bbe91df7e945f42c3ca
> Cr-Commit-Position: refs/heads/master@{#405138}

TBR=hidehiko@chromium.org,stevenjb@chromium.org,lhchavez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=626695

Committed: https://crrev.com/03b1e37434a736bbb5c764dd980787e54c93868b
Cr-Commit-Position: refs/heads/master@{#405165}
==========

[commit-bot: I haz the power, 2016-07-13 15:54:27]

Patchset 1 (id:??) landed as
https://crrev.com/03b1e37434a736bbb5c764dd980787e54c93868b
Cr-Commit-Position: refs/heads/master@{#405165}

[Luis Héctor Chávez, 2016-07-13 16:24:52]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2144013002/ by lhchavez@chromium.org.

The reason for reverting is: https://codereview.chromium.org/2150583002 should
fix the underlying issue that this change surfaced..