Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2146573004: [turbofan] Remove fallback to TurboFan when Crankshaft bails out. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove fallback to TurboFan when Crankshaft bails out. This removes the fallback path in question. Now the {AstNumbering} phase is the only phase deciding whether Crankshaft is supposed to be disabled or not. This in turn simplifies reasoning about the paths through the compilation pipeline. We can decide early whether we want Ignition to kick in depending on whether Crankshaft is enabled or not. R=mvstanton@chromium.org,rmcilroy@chromium.org Committed: https://crrev.com/8bad9474492c96906c57ee625db0e08080455719 Cr-Commit-Position: refs/heads/master@{#37763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -25 lines) Patch
M src/compiler.h View 2 chunks +1 line, -21 lines 0 comments Download
M src/compiler.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Michael Starzinger
Michael & Ross: PTAL. Danno & Jakob: FYI.
4 years, 5 months ago (2016-07-13 11:34:44 UTC) #3
rmcilroy
On 2016/07/13 11:34:44, Michael Starzinger wrote: > Michael & Ross: PTAL. > Danno & Jakob: ...
4 years, 5 months ago (2016-07-13 14:47:58 UTC) #5
mvstanton
LGTM
4 years, 5 months ago (2016-07-13 14:51:14 UTC) #6
danno
lgtm
4 years, 5 months ago (2016-07-14 06:00:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146573004/1
4 years, 5 months ago (2016-07-14 12:38:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 13:05:21 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 13:06:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bad9474492c96906c57ee625db0e08080455719
Cr-Commit-Position: refs/heads/master@{#37763}

Powered by Google App Engine
This is Rietveld 408576698