Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: net/nqe/network_quality_estimator.h

Issue 2146563002: Expose effective connection type to Cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/nqe/network_quality_estimator.h
diff --git a/net/nqe/network_quality_estimator.h b/net/nqe/network_quality_estimator.h
index afeca4eb01e1220879cb01bf87a644ebe06a9775..2e7de064e364ea78668f13524e6a8f3217d4dd03 100644
--- a/net/nqe/network_quality_estimator.h
+++ b/net/nqe/network_quality_estimator.h
@@ -64,6 +64,11 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimator
// EffectiveConnectionType of a network is independent of if the current
// connection is metered or not. For example, an unmetered slow connection may
// have EFFECTIVE_CONNECTION_TYPE_SLOW_2G as its effective connection type.
+ // An invalid Java prefix is specified to prevent the Java class generator
+ // from automatically stripping off the common prefix
+ // ("EFFECTIVE_CONNECTION_TYPE_").
+ // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.net
+ // GENERATED_JAVA_PREFIX_TO_STRIP: PREFIX_NOT_PRESENT_
enum EffectiveConnectionType {
// The connection types should be in increasing order of quality.
EFFECTIVE_CONNECTION_TYPE_UNKNOWN = 0,
@@ -596,6 +601,11 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimator
nqe::internal::NetworkQuality
default_observations_[NetworkChangeNotifier::CONNECTION_LAST + 1];
+ // Default thresholds for different effective connection types. The default
+ // values are used if thresholds are unavailable from the variation params.
+ nqe::internal::NetworkQuality
+ default_connection_thresholds_[EFFECTIVE_CONNECTION_TYPE_LAST];
+
// Thresholds for different effective connection types obtained from field
// trial variation params. These thresholds encode how different connection
// types behave in general. In future, complex encodings (e.g., curve

Powered by Google App Engine
This is Rietveld 408576698