components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java - Issue 2146563002: Expose effective connection type to Cronet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

Issue 2146563002: Expose effective connection type to Cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased, addressed Paul comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java ('K') | « components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java ('k') | net/nqe/effective_connection_type.h » ('j') | net/nqe/effective_connection_type.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

index ec7d4611d2c47045b2e3b149e9e06f0582461d07..246fb18d3fc6b0fba68357c884fbee26304c75d2 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

@@ -222,6 +222,11 @@ public class QuicTest extends CronetTestBase {

// NETWORK_QUALITY_OBSERVATION_SOURCE_QUIC

assertTrue(rttListener.rttObservationCount(2) > 0);

+ // Verify that effective connection type callback is received and

+ // effective connection type is correctly set.

+ assertTrue(mTestFramework.mCronetEngine.getEffectiveConnectionType()

+ != EffectiveConnectionType.EFFECTIVE_CONNECTION_TYPE_UNKNOWN);

mTestFramework.mCronetEngine.shutdown();

}