components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java - Issue 2146563002: Expose effective connection type to Cronet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java

Issue 2146563002: Expose effective connection type to Cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased, addressed Paul comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/api/src/org/chromium/net/EffectiveConnectionType.java ('K') | « components/cronet/android/api/src/org/chromium/net/EffectiveConnectionType.java ('k') | components/cronet/android/cronet_url_request_context_adapter.h » ('j') | net/nqe/effective_connection_type.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java

diff --git a/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java b/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java

index c18e4b21a3907392506e1dc99fdd5ba0325fe380..766869f6160aea85126cdde565a24ba69ad12c73 100644

--- a/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java

+++ b/components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java

@@ -104,6 +104,12 @@ final class JavaCronetEngine extends CronetEngine {

}

@Override

xunjieli 2016/08/01 21:25:09 nit: new line not needed.

tbansal1 2016/08/02 19:03:11 Done.

+ public EffectiveConnectionType getEffectiveConnectionType() {

+ return EffectiveConnectionType.EFFECTIVE_CONNECTION_TYPE_UNKNOWN;

+ }

+ @Override

public void configureNetworkQualityEstimatorForTesting(

boolean useLocalHostRequests, boolean useSmallerResponses) {}