chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js - Issue 2146553005: MD Settings: Bluetooth: Add error dialog and messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js

Issue 2146553005: MD Settings: Bluetooth: Add error dialog and messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_602538_bluetooth_fixes_0

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html ('k') | chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html » ('j') | chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js

diff --git a/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js b/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js

index 82aa144ad7774b8cc4118b214538aa586c4e39c7..619b3ebabea6a19d410e1cb3296005be2f088678 100644

--- a/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js

+++ b/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js

@@ -357,9 +357,9 @@ Polymer({

* @return {string} The title of for that |dialogId|.

getTitle_: function(dialogId) {

- return this.i18n(

- dialogId == 'addDevice' ? 'bluetoothAddDevicePageTitle' :

- 'bluetoothPairDevicePageTitle');

+ if (dialogId == 'addDevice')

+ return this.i18n('bluetoothAddDevicePageTitle');

+ return this.i18n('bluetoothPairDevicePageTitle');

Dan Beam 2016/07/13 01:35:11 what's the functional difference here?

stevenjb 2016/07/13 17:26:43 None, it just seems more clear to me now that ther

/**