MD Settings: Bluetooth: Add error dialog and messages

chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.exportPath('settings');
 
 (function() {
 
 var PairingEventType = chrome.bluetoothPrivate.PairingEventType;
 
@@ skipping 339 matching lines @@
   close: function() { this.$.dialog.close(); },
 
   /** @private */
   deviceListChanged_: function(e) { this.$.dialog.notifyResize(); },
 
   /**
    * @param {string} dialogId
    * @return {string} The title of for that |dialogId|.
    */
   getTitle_: function(dialogId) {
-    return this.i18n(
-        dialogId == 'addDevice' ? 'bluetoothAddDevicePageTitle' :
-                                  'bluetoothPairDevicePageTitle');
+    if (dialogId == 'addDevice')
+      return this.i18n('bluetoothAddDevicePageTitle');
+    return this.i18n('bluetoothPairDevicePageTitle');

[Dan Beam, 2016/07/13 01:35:11]

what's the functional difference here?

[stevenjb, 2016/07/13 17:26:43]

None, it just seems more clear to me now that there are more than two options
(pairDevice and connectError both use this title). Added a comment.

   },
 
   /**
    * @param {string} currentDialogType
    * @param {string} wantedDialogType
    * @return {boolean}
    * @private
    */
   isDialogType_: function(currentDialogType, wantedDialogType) {
     return currentDialogType == wantedDialogType;
@@ skipping 11 matching lines @@
   onIronOverlayCanceled_: function() {
     if (this.dialogId == 'pairDevice')
       this.sendResponse_(chrome.bluetoothPrivate.PairingResponse.CANCEL);
   },
 
   /** @private */
   onIronOverlayClosed_: function() { this.fire('close-dialog', ''); },
 });
 
 })();