Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2146553003: Support C++11 types in build/include_what_you_use (Closed)

Created:
4 years, 5 months ago by Luis Héctor Chávez
Modified:
4 years, 5 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support C++11 types in build/include_what_you_use This is a cherry-pick of https://github.com/google/styleguide/pull/159 (plus some code that it depends on). BUG=627514 TEST=cpplint_unittest.py Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/2d1b6dae5acc5c7580668a1d8e12e33c46774782

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M cpplint.py View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Luis Héctor Chávez
PTAL dpranke for OWNERS erg for GitHub pull request review
4 years, 5 months ago (2016-07-12 16:59:13 UTC) #2
Dirk Pranke
style-wise, this lgtm. I have no idea if these changes are all legit, though, so ...
4 years, 5 months ago (2016-07-12 19:11:00 UTC) #4
danakj
LGTM
4 years, 5 months ago (2016-07-12 19:49:11 UTC) #5
Elliot Glaysher
(merged on github)
4 years, 5 months ago (2016-07-13 17:23:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146553003/1
4 years, 5 months ago (2016-07-13 17:23:32 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/791)
4 years, 5 months ago (2016-07-13 17:28:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146553003/20001
4 years, 5 months ago (2016-07-13 17:37:07 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:40:05 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/2d1b6dae5acc5c...

Powered by Google App Engine
This is Rietveld 408576698