Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2048)

Unified Diff: appengine/chromium_rietveld/codereview/views_chromium.py

Issue 2146523002: Rietveld: don't email if CQ unchecked the commit message. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/chromium_rietveld/codereview/views_chromium.py
diff --git a/appengine/chromium_rietveld/codereview/views_chromium.py b/appengine/chromium_rietveld/codereview/views_chromium.py
index 212096036ea73bc3acb3863c2df504b8df1dccb4..64100543566efa2ad7a10667f7135902a0eddd6e 100644
--- a/appengine/chromium_rietveld/codereview/views_chromium.py
+++ b/appengine/chromium_rietveld/codereview/views_chromium.py
@@ -393,13 +393,14 @@ def edit_flags(request):
request.issue.cq_dry_run_last_triggered_by = user_email
logging.info('CQ dry run has been triggered by %s for %d/%d', user_email,
request.issue.key.id(), last_patchset.key.id())
- # Mail just the owner if the CQ bit was unchecked by someone other than the
- # owner. More details in
+ # Mail just the owner and only if the CQ bit was unchecked by someone other
+ # than the owner or CQ itself. More details in
# https://code.google.com/p/skia/issues/detail?id=3093
- unchecked_by_non_owner = (user_email != request.issue.owner.email() and
- not request.issue.commit)
+ send_mail = (user_email != request.issue.owner.email() and
+ user_email != views.CQ_COMMIT_BOT_EMAIL and
+ not request.issue.commit)
views.make_message(request, request.issue, commit_checked_msg,
- send_mail=unchecked_by_non_owner, auto_generated=True,
+ send_mail=send_mail, auto_generated=True,
email_to=[request.issue.owner.email()]).put()
request.issue.put()
if request.issue.commit and not request.issue.cq_dry_run:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698