Remove RichText support from fpdfsdk/fxedit.

Remove RichText support from fpdfsdk/fxedit.

This CL removes the support code for RichText from fxedit as it is currently unused.

Committed: https://pdfium.googlesource.com/pdfium/+/a2919b31197737d35e4e1df53b02f7ee7cb4cf5e

[dsinclair, 2016-07-12 15:20:20]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, weili@chromium.org

[dsinclair, 2016-07-12 15:20:20]

PTAL.

[Wei Li, 2016-07-12 17:56:54]

https://codereview.chromium.org/2146503002/diff/1/fpdfsdk/fxedit/include/fx_e...
File fpdfsdk/fxedit/include/fx_edit.h (left):

https://codereview.chromium.org/2146503002/diff/1/fpdfsdk/fxedit/include/fx_e...
fpdfsdk/fxedit/include/fx_edit.h:246: virtual FX_BOOL IsRichText() const = 0;
Are we removing (potential) support for rich text? If so, this could be removed.
Ditto for SetRichText(). Also, there might be ripple effects. Would we remove
the rich text support in CPDF_VariableText as it is mostly used here?

[dsinclair, 2016-07-12 18:09:33]

https://codereview.chromium.org/2146503002/diff/1/fpdfsdk/fxedit/include/fx_e...
File fpdfsdk/fxedit/include/fx_edit.h (left):

https://codereview.chromium.org/2146503002/diff/1/fpdfsdk/fxedit/include/fx_e...
fpdfsdk/fxedit/include/fx_edit.h:246: virtual FX_BOOL IsRichText() const = 0;
On 2016/07/12 17:56:53, Wei Li wrote:
> Are we removing (potential) support for rich text? If so, this could be
removed.
> Ditto for SetRichText(). Also, there might be ripple effects. Would we remove
> the rich text support in CPDF_VariableText as it is mostly used here?


I removed the below because they're never called. The above are called, so they
probably need a deeper look to determine if they can be removed.

I don't see anything in CPDF_VariableText that can be removed due to this CL.

[Wei Li, 2016-07-12 21:15:32]

https://codereview.chromium.org/2146503002/diff/1/fpdfsdk/fxedit/include/fx_e...
File fpdfsdk/fxedit/include/fx_edit.h (left):

https://codereview.chromium.org/2146503002/diff/1/fpdfsdk/fxedit/include/fx_e...
fpdfsdk/fxedit/include/fx_edit.h:246: virtual FX_BOOL IsRichText() const = 0;
On 2016/07/12 18:09:33, dsinclair wrote:
> On 2016/07/12 17:56:53, Wei Li wrote:
> > Are we removing (potential) support for rich text? If so, this could be
> removed.
> > Ditto for SetRichText(). Also, there might be ripple effects. Would we
remove
> > the rich text support in CPDF_VariableText as it is mostly used here?
> 
> 
> I removed the below because they're never called. The above are called, so
they
> probably need a deeper look to determine if they can be removed.
> 
> I don't see anything in CPDF_VariableText that can be removed due to this CL.

Where IsRichText() and SetRichText() are called?

[dsinclair, 2016-07-13 13:50:48]

Patchset #2 (id:20001) has been deleted

[dsinclair, 2016-07-13 13:51:15]

https://codereview.chromium.org/2146503002/diff/1/fpdfsdk/fxedit/include/fx_e...
File fpdfsdk/fxedit/include/fx_edit.h (left):

https://codereview.chromium.org/2146503002/diff/1/fpdfsdk/fxedit/include/fx_e...
fpdfsdk/fxedit/include/fx_edit.h:246: virtual FX_BOOL IsRichText() const = 0;
On 2016/07/12 21:15:31, Wei Li wrote:
> On 2016/07/12 18:09:33, dsinclair wrote:
> > On 2016/07/12 17:56:53, Wei Li wrote:
> > > Are we removing (potential) support for rich text? If so, this could be
> > removed.
> > > Ditto for SetRichText(). Also, there might be ripple effects. Would we
> remove
> > > the rich text support in CPDF_VariableText as it is mostly used here?
> > 
> > 
> > I removed the below because they're never called. The above are called, so
> they
> > probably need a deeper look to determine if they can be removed.
> > 
> > I don't see anything in CPDF_VariableText that can be removed due to this
CL.
> 
> Where IsRichText() and SetRichText() are called?


Looked again and you're right. The calls to SetRichText were for the Field::
class, which didn't do anything and the call to set it onto VariableText from
within the edit SetRichText.

Removed the calls to SetRichText and IsRichText and their supporting code.

[Wei Li, 2016-07-13 17:44:04]

lgtm

Based on the current scope of change, please consider changing the title to
include sth like "remove richtext support/feature".

[dsinclair, 2016-07-13 17:55:25]

Description was changed from

==========
Remove unused methods from fpdfsdk/fxedit.

This CL removes several methods from the fxedit library. Many of the removed
methods are around rich text editing.
==========

to

==========
Remove RichText support from fpdfsdk/fxedit.

This CL removes the support code for RichText from fxedit as it is currently
unused.
==========

[dsinclair, 2016-07-13 17:55:30]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-07-13 17:55:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 17:55:55]

Description was changed from

==========
Remove RichText support from fpdfsdk/fxedit.

This CL removes the support code for RichText from fxedit as it is currently
unused.
==========

to

==========
Remove RichText support from fpdfsdk/fxedit.

This CL removes the support code for RichText from fxedit as it is currently
unused.

Committed:
https://pdfium.googlesource.com/pdfium/+/a2919b31197737d35e4e1df53b02f7ee7cb4...
==========

[commit-bot: I haz the power, 2016-07-13 17:55:56]

Committed patchset #3 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/a2919b31197737d35e4e1df53b02f7ee7cb4...