Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: src/interpreter/control-flow-builders.h

Issue 2146493002: Move catch prediction into frontend. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Disable test on Turbofan Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecode-generator.cc ('k') | src/interpreter/control-flow-builders.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/control-flow-builders.h
diff --git a/src/interpreter/control-flow-builders.h b/src/interpreter/control-flow-builders.h
index b72d6d5f0f5c8ff9be33dfc420726c670ca35707..dd8303ad9a0d37d8bbf88ebd5b7743d22f9b7870 100644
--- a/src/interpreter/control-flow-builders.h
+++ b/src/interpreter/control-flow-builders.h
@@ -144,8 +144,10 @@ class SwitchBuilder final : public BreakableControlFlowBuilder {
// A class to help with co-ordinating control flow in try-catch statements.
class TryCatchBuilder final : public ControlFlowBuilder {
public:
- explicit TryCatchBuilder(BytecodeArrayBuilder* builder)
- : ControlFlowBuilder(builder), handler_id_(builder->NewHandlerEntry()) {}
+ explicit TryCatchBuilder(BytecodeArrayBuilder* builder, bool catch_predicted)
+ : ControlFlowBuilder(builder),
+ handler_id_(builder->NewHandlerEntry()),
+ catch_predicted_(catch_predicted) {}
void BeginTry(Register context);
void EndTry();
@@ -153,6 +155,7 @@ class TryCatchBuilder final : public ControlFlowBuilder {
private:
int handler_id_;
+ bool catch_predicted_;
BytecodeLabel handler_;
BytecodeLabel exit_;
};
@@ -161,11 +164,12 @@ class TryCatchBuilder final : public ControlFlowBuilder {
// A class to help with co-ordinating control flow in try-finally statements.
class TryFinallyBuilder final : public ControlFlowBuilder {
public:
- explicit TryFinallyBuilder(BytecodeArrayBuilder* builder, bool will_catch)
+ explicit TryFinallyBuilder(BytecodeArrayBuilder* builder,
+ bool catch_predicted)
: ControlFlowBuilder(builder),
handler_id_(builder->NewHandlerEntry()),
- finalization_sites_(builder->zone()),
- will_catch_(will_catch) {}
+ catch_predicted_(catch_predicted),
+ finalization_sites_(builder->zone()) {}
void BeginTry(Register context);
void LeaveTry();
@@ -176,15 +180,11 @@ class TryFinallyBuilder final : public ControlFlowBuilder {
private:
int handler_id_;
+ bool catch_predicted_;
BytecodeLabel handler_;
// Unbound labels that identify jumps to the finally block in the code.
ZoneVector<BytecodeLabel> finalization_sites_;
-
- // Conservative prediction of whether exceptions thrown into the handler for
- // this finally block will be caught. Note that such a prediction depends on
- // whether this try-finally is nested inside a surrounding try-catch.
- bool will_catch_;
};
} // namespace interpreter
« no previous file with comments | « src/interpreter/bytecode-generator.cc ('k') | src/interpreter/control-flow-builders.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698