third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp - Issue 2146453002: BodyStreamBuffer shouldn't run scripts when ActiveDOMObjects are stopped

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

Issue 2146453002: BodyStreamBuffer shouldn't run scripts when ActiveDOMObjects are stopped (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

index a339b1ecd5c3102b53769531af7d2b6cc6702c4a..c069cfd850ac2fb393c837b6868e214e07f6e8bb 100644

--- a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

+++ b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

@@ -274,7 +274,7 @@ ScriptPromise BodyStreamBuffer::cancel(ScriptState* scriptState, ScriptValue rea

void BodyStreamBuffer::didGetReadable()

{

- if (!m_reader)

+ if (!m_reader || !m_scriptState->getExecutionContext() || m_scriptState->getExecutionContext()->activeDOMObjectsAreStopped())

haraken 2016/07/12 10:29:51 Would it be better to clear m_reader when contextD

return;

if (!m_streamNeedsMore) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »