Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2146443003: [turbofan] Ship type feedback for binary operators. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ship type feedback for binary operators. R=jarin@chromium.org BUG=v8:4583 Committed: https://crrev.com/2a7b64d1c74013f8c9a301a66cf39ddfe5921f87 Cr-Commit-Position: refs/heads/master@{#37697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/flag-definitions.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-13 04:23:30 UTC) #1
Benedikt Meurer
Hey Jaro, Weaponizing your baby and releasing it to the cruel world. Please take a ...
4 years, 5 months ago (2016-07-13 04:24:55 UTC) #4
Jarin
lgtm
4 years, 5 months ago (2016-07-13 04:27:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146443003/1
4 years, 5 months ago (2016-07-13 04:39:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 04:49:06 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 04:49:08 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 04:50:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a7b64d1c74013f8c9a301a66cf39ddfe5921f87
Cr-Commit-Position: refs/heads/master@{#37697}

Powered by Google App Engine
This is Rietveld 408576698