Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: scripts/slave/recipe_modules/chromium_android/example.py

Issue 2146433003: [Android] Reland splitting of device recovery and device status. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_android/example.py
diff --git a/scripts/slave/recipe_modules/chromium_android/example.py b/scripts/slave/recipe_modules/chromium_android/example.py
index b127f746887e24429b3a2dd643a133b091492669..d34772c08a397bd6017cfbefac5389d4eb7da9e7 100644
--- a/scripts/slave/recipe_modules/chromium_android/example.py
+++ b/scripts/slave/recipe_modules/chromium_android/example.py
@@ -156,6 +156,7 @@ def RunSteps(api, buildername):
try:
# TODO(luqui): remove redundant cruft, need one consistent API.
api.chromium_android.detect_and_setup_devices()
+ api.chromium_android.device_status_check()
api.path.mock_add_paths(api.chromium_android.known_devices_file)
api.chromium_android.device_status_check(
@@ -249,13 +250,21 @@ def GenTests(api):
for buildername in BUILDERS:
yield api.test('%s_basic' % buildername) + properties_for(buildername)
- yield (api.test('tester_no_devices') +
+ yield (api.test('tester_no_devices_during_recovery') +
properties_for('tester') +
- api.step_data('device_status_check', retcode=1))
+ api.step_data('device_recovery', retcode=1))
- yield (api.test('tester_other_device_failure') +
+ yield (api.test('tester_no_devices_during_status') +
properties_for('tester') +
- api.step_data('device_status_check', retcode=2))
+ api.step_data('device_status', retcode=1))
+
+ yield (api.test('tester_other_device_failure_during_recovery') +
+ properties_for('tester') +
+ api.step_data('device_recovery', retcode=2))
+
+ yield (api.test('tester_other_device_failure_during_status') +
+ properties_for('tester') +
+ api.step_data('device_status', retcode=2))
yield (api.test('tester_with_step_warning') +
properties_for('tester') +
@@ -268,7 +277,7 @@ def GenTests(api):
yield (api.test('tester_offline_devices') +
properties_for('tester') +
- api.override_step_data('device_status_check',
+ api.override_step_data('device_status',
api.json.output([{}, {}])))
yield (api.test('perf_tests_failure') +

Powered by Google App Engine
This is Rietveld 408576698