[Android] Reland splitting of device recovery and device status.

scripts/slave/recipe_modules/cronet/example.expected/local_test.json

 [
   {
     "cmd": [
       "python",
       "-u",
       "\nimport os, sys\n\nbuild_path = sys.argv[1]\nif os.path.exists(build_path):\n  for (path, dir, files) in os.walk(build_path):\n    for cur_file in files:\n      if cur_file.endswith('index.lock'):\n        path_to_file = os.path.join(path, cur_file)\n        print 'deleting %s' % path_to_file\n        os.remove(path_to_file)\n",
       "[SLAVE_BUILD]"
     ],
     "name": "cleanup index.lock",
     "~followup_annotations": [
@@ skipping 359 matching lines @@
       "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools/adb"
     ],
     "env": {
       "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",
       "PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s"
     },
     "name": "authorize_adb_devices"
   },
   {
     "cmd": [
-      "[SLAVE_BUILD]/src/build/android/buildbot/bb_device_status_check.py",
+      "[SLAVE_BUILD]/src/third_party/catapult/devil/devil/android/tools/device_recovery.py",
+      "--blacklist-file",
+      "[SLAVE_BUILD]/src/out/bad_devices.json",
+      "--known-devices-file",
+      "[HOME]/.android/known_devices.json",
       "--adb-path",
       "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools/adb",
-      "--blacklist-file",
-      "[SLAVE_BUILD]/src/out/bad_devices.json",
-      "--json-output",
-      "/path/to/tmp/json",
-      "--known-devices-file",
-      "[HOME]/.android/known_devices.json"
+      "-v"
     ],
     "env": {
       "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",
       "PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s"
     },
-    "name": "device_status_check",
+    "name": "device_recovery"
+  },
+  {
+    "cmd": [
+      "python",
+      "-u",
+      "[SLAVE_BUILD]/src/build/android/provision_devices.py",
+      "--adb-path",
+      "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools/adb",
+      "--blacklist-file",
+      "[SLAVE_BUILD]/src/out/bad_devices.json",
+      "--output-device-blacklist",
+      "/path/to/tmp/json",
+      "-t",
+      "Debug"
+    ],
+    "env": {
+      "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",
+      "PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s"
+    },
+    "name": "provision_devices"
+  },
+  {
+    "cmd": [
+      "[SLAVE_BUILD]/src/third_party/catapult/devil/devil/android/tools/device_status.py",
+      "--json-output",
+      "/path/to/tmp/json",
+      "--blacklist-file",
+      "[SLAVE_BUILD]/src/out/bad_devices.json",
+      "--known-devices-file",
+      "[HOME]/.android/known_devices.json",
+      "--buildbot-path",
+      "/home/chrome-bot/.adb_device_info",
+      "--adb-path",
+      "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools/adb",
+      "-v",
+      "--overwrite-known-devices-files"
+    ],
+    "env": {
+      "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",
+      "PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s"
+    },
+    "name": "device_status",
     "~followup_annotations": [
       "@@@STEP_TEXT@Online devices: 1@@@",
       "@@@STEP_LOG_LINE@json.output@[@@@",
       "@@@STEP_LOG_LINE@json.output@  {@@@",
       "@@@STEP_LOG_LINE@json.output@    \"adb_status\": \"device\", @@@",
       "@@@STEP_LOG_LINE@json.output@    \"battery\": {@@@",
       "@@@STEP_LOG_LINE@json.output@      \"AC powered\": \"false\", @@@",
       "@@@STEP_LOG_LINE@json.output@      \"USB powered\": \"true\", @@@",
       "@@@STEP_LOG_LINE@json.output@      \"Wireless powered\": \"false\", @@@",
       "@@@STEP_LOG_LINE@json.output@      \"health\": \"2\", @@@",
       "@@@STEP_LOG_LINE@json.output@      \"level\": \"100\", @@@",
       "@@@STEP_LOG_LINE@json.output@      \"present\": \"true\", @@@",
       "@@@STEP_LOG_LINE@json.output@      \"scale\": \"100\", @@@",
       "@@@STEP_LOG_LINE@json.output@      \"status\": \"5\", @@@",
       "@@@STEP_LOG_LINE@json.output@      \"technology\": \"Li-ion\", @@@",
       "@@@STEP_LOG_LINE@json.output@      \"temperature\": \"249\", @@@",
       "@@@STEP_LOG_LINE@json.output@      \"voltage\": \"4286\"@@@",
       "@@@STEP_LOG_LINE@json.output@    }, @@@",
       "@@@STEP_LOG_LINE@json.output@    \"blacklisted\": false, @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"build\": \"LRX21O\", @@@",
       "@@@STEP_LOG_LINE@json.output@    \"build_detail\": \"google/razor/flo:5.0/LRX21O/1570415:userdebug/dev-keys\", @@@",
       "@@@STEP_LOG_LINE@json.output@    \"imei_slice\": \"Unknown\", @@@",
+      "@@@STEP_LOG_LINE@json.output@    \"ro.build.id\": \"LRX21O\", @@@",
+      "@@@STEP_LOG_LINE@json.output@    \"ro.build.product\": \"product_name\", @@@",
       "@@@STEP_LOG_LINE@json.output@    \"serial\": \"07a00ca4\", @@@",
-      "@@@STEP_LOG_LINE@json.output@    \"type\": \"flo\", @@@",
       "@@@STEP_LOG_LINE@json.output@    \"usb_status\": true, @@@",
       "@@@STEP_LOG_LINE@json.output@    \"wifi_ip\": \"\"@@@",
       "@@@STEP_LOG_LINE@json.output@  }, @@@",
       "@@@STEP_LOG_LINE@json.output@  {@@@",
       "@@@STEP_LOG_LINE@json.output@    \"adb_status\": \"offline\", @@@",
       "@@@STEP_LOG_LINE@json.output@    \"blacklisted\": true, @@@",
       "@@@STEP_LOG_LINE@json.output@    \"serial\": \"03e0363a003c6ad4\", @@@",
       "@@@STEP_LOG_LINE@json.output@    \"usb_status\": false@@@",
       "@@@STEP_LOG_LINE@json.output@  }, @@@",
       "@@@STEP_LOG_LINE@json.output@  {@@@",
       "@@@STEP_LOG_LINE@json.output@    \"adb_status\": \"unauthorized\", @@@",
       "@@@STEP_LOG_LINE@json.output@    \"blacklisted\": true, @@@",
       "@@@STEP_LOG_LINE@json.output@    \"serial\": \"03e0363a003c6ad5\", @@@",
       "@@@STEP_LOG_LINE@json.output@    \"usb_status\": true@@@",
       "@@@STEP_LOG_LINE@json.output@  }, @@@",
       "@@@STEP_LOG_LINE@json.output@  {@@@",
       "@@@STEP_LOG_LINE@json.output@    \"adb_status\": \"device\", @@@",
       "@@@STEP_LOG_LINE@json.output@    \"blacklisted\": true, @@@",
       "@@@STEP_LOG_LINE@json.output@    \"serial\": \"03e0363a003c6ad6\", @@@",
       "@@@STEP_LOG_LINE@json.output@    \"usb_status\": true@@@",
       "@@@STEP_LOG_LINE@json.output@  }@@@",
       "@@@STEP_LOG_LINE@json.output@]@@@",
       "@@@STEP_LOG_END@json.output@@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@{@@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@  \"adb_status\": \"device\", @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@  \"battery\": {@@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@    \"AC powered\": \"false\", @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@    \"USB powered\": \"true\", @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@    \"Wireless powered\": \"false\", @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@    \"health\": \"2\", @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@    \"level\": \"100\", @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@    \"present\": \"true\", @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@    \"scale\": \"100\", @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@    \"status\": \"5\", @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@    \"technology\": \"Li-ion\", @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@    \"temperature\": \"249\", @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@    \"voltage\": \"4286\"@@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@  }, @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@  \"blacklisted\": false, @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@  \"build\": \"LRX21O\", @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@  \"build_detail\": \"google/razor/flo:5.0/LRX21O/1570415:userdebug/dev-keys\", @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@  \"imei_slice\": \"Unknown\", @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@  \"serial\": \"07a00ca4\", @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@  \"type\": \"flo\", @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@  \"usb_status\": true, @@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@  \"wifi_ip\": \"\"@@@",
-      "@@@STEP_LOG_LINE@flo LRX21O 07a00ca4@}@@@",
-      "@@@STEP_LOG_END@flo LRX21O 07a00ca4@@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@{@@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@  \"adb_status\": \"device\", @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@  \"battery\": {@@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@    \"AC powered\": \"false\", @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@    \"USB powered\": \"true\", @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@    \"Wireless powered\": \"false\", @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@    \"health\": \"2\", @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@    \"level\": \"100\", @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@    \"present\": \"true\", @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@    \"scale\": \"100\", @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@    \"status\": \"5\", @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@    \"technology\": \"Li-ion\", @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@    \"temperature\": \"249\", @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@    \"voltage\": \"4286\"@@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@  }, @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@  \"blacklisted\": false, @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@  \"build_detail\": \"google/razor/flo:5.0/LRX21O/1570415:userdebug/dev-keys\", @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@  \"imei_slice\": \"Unknown\", @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@  \"ro.build.id\": \"LRX21O\", @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@  \"ro.build.product\": \"product_name\", @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@  \"serial\": \"07a00ca4\", @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@  \"usb_status\": true, @@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@  \"wifi_ip\": \"\"@@@",
+      "@@@STEP_LOG_LINE@product_name LRX21O 07a00ca4@}@@@",
+      "@@@STEP_LOG_END@product_name LRX21O 07a00ca4@@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad4: missing@{@@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad4: missing@  \"adb_status\": \"offline\", @@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad4: missing@  \"blacklisted\": true, @@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad4: missing@  \"serial\": \"03e0363a003c6ad4\", @@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad4: missing@  \"usb_status\": false@@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad4: missing@}@@@",
       "@@@STEP_LOG_END@03e0363a003c6ad4: missing@@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad5: adb status unauthorized@{@@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad5: adb status unauthorized@  \"adb_status\": \"unauthorized\", @@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad5: adb status unauthorized@  \"blacklisted\": true, @@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad5: adb status unauthorized@  \"serial\": \"03e0363a003c6ad5\", @@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad5: adb status unauthorized@  \"usb_status\": true@@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad5: adb status unauthorized@}@@@",
       "@@@STEP_LOG_END@03e0363a003c6ad5: adb status unauthorized@@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad6: blacklisted@{@@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad6: blacklisted@  \"adb_status\": \"device\", @@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad6: blacklisted@  \"blacklisted\": true, @@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad6: blacklisted@  \"serial\": \"03e0363a003c6ad6\", @@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad6: blacklisted@  \"usb_status\": true@@@",
       "@@@STEP_LOG_LINE@03e0363a003c6ad6: blacklisted@}@@@",
       "@@@STEP_LOG_END@03e0363a003c6ad6: blacklisted@@@"
     ]
   },
   {
     "cmd": [
       "python",
       "-u",
-      "[SLAVE_BUILD]/src/build/android/provision_devices.py",
-      "--adb-path",
-      "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools/adb",
-      "--blacklist-file",
-      "[SLAVE_BUILD]/src/out/bad_devices.json",
-      "--output-device-blacklist",
-      "/path/to/tmp/json",
-      "-t",
-      "Debug"
-    ],
-    "env": {
-      "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",
-      "PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s"
-    },
-    "name": "provision_devices"
-  },
-  {
-    "cmd": [
-      "python",
-      "-u",
       "RECIPE_PACKAGE_REPO[build]/scripts/slave/daemonizer.py",
       "--action",
       "restart",
       "--pid-file-path",
       "/tmp/device_monitor.pid",
       "--",
       "RECIPE_MODULE[build::chromium_android]/resources/spawn_device_monitor.py",
       "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools/adb",
       "[\"07a00ca4\"]",
       "--blacklist-file",
@@ skipping 170 matching lines @@
       "@@@STEP_LOG_LINE@python.inline@  os.remove(report)@@@",
       "@@@STEP_LOG_END@python.inline@@@"
     ]
   },
   {
     "name": "$result",
     "recipe_result": null,
     "status_code": 0
   }
 ]