Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Issue 214643005: chromeos: Remove --ash-enable-brightness-control flag. (Closed)

Created:
6 years, 9 months ago by Daniel Erat
Modified:
6 years, 9 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

chromeos: Remove --ash-enable-brightness-control flag. Enable the brightness keys unconditionally (i.e. also on systems that lack internal displays). BUG=chromium:315371 R=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260287

Patch Set 1 #

Patch Set 2 : delete some outdated brightness accelerator tests that i didn't know about #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -50 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 chunk +1 line, -7 lines 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 1 2 chunks +0 lines, -25 lines 0 comments Download
M ash/ash_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Daniel Erat
6 years, 9 months ago (2014-03-27 18:56:22 UTC) #1
stevenjb
lgtm
6 years, 9 months ago (2014-03-27 19:44:17 UTC) #2
Daniel Erat
The CQ bit was checked by derat@chromium.org
6 years, 9 months ago (2014-03-27 20:23:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/214643005/1
6 years, 9 months ago (2014-03-27 20:25:58 UTC) #4
Daniel Erat
The CQ bit was unchecked by derat@chromium.org
6 years, 9 months ago (2014-03-27 22:54:53 UTC) #5
Daniel Erat
The CQ bit was checked by derat@chromium.org
6 years, 9 months ago (2014-03-27 23:08:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/214643005/20001
6 years, 9 months ago (2014-03-27 23:10:22 UTC) #7
Daniel Erat
6 years, 9 months ago (2014-03-28 21:38:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r260287 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698