Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2146403005: SkPDF: Always give a default advance for glyphs. (Closed)

Created:
4 years, 5 months ago by hal.canary
Modified:
4 years, 5 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: Always give a default advance for glyphs. Prior to this we assumed the default default was 0. It is actually 1000, according to the spec. fixes BUG=skia:5321 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146403005 Committed: https://skia.googlesource.com/skia/+/39f988eb415bd697ce11933ca2a341ae6fbf9030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -5 lines) Patch
A gm/skbug_5321.cpp View 1 chunk +33 lines, -0 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
hal.canary
PTAL. This is exacly what we just discussed.
4 years, 5 months ago (2016-07-15 16:46:37 UTC) #5
bungeman-skia
lgtm
4 years, 5 months ago (2016-07-15 19:40:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146403005/1
4 years, 5 months ago (2016-07-15 19:41:10 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 19:54:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/39f988eb415bd697ce11933ca2a341ae6fbf9030

Powered by Google App Engine
This is Rietveld 408576698