third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp - Issue 2146403004: ThreadableLoader::cancel should be called before loader destruction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp

Issue 2146403004: ThreadableLoader::cancel should be called before loader destruction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-threadable-loader-client-wrapper

Patch Set: fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp b/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp

index 3f1bb858dc5ace992f3aba7a13eb26f7da56d4cb..ba8f1427a912edba0dc49c6a53572564871a47bf 100644

--- a/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp

@@ -78,6 +78,7 @@ void WorkerThreadableLoader::loadResourceSynchronously(WorkerGlobalScope& worker

WorkerThreadableLoader::~WorkerThreadableLoader()

{

+ DCHECK(m_workerClientWrapper->done());

m_bridge->destroy();

m_bridge = nullptr;

}

« no previous file with comments | « third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp ('k') | no next file » | no next file with comments »