third_party/WebKit/Source/core/fileapi/FileReaderLoader.h - Issue 2146403004: ThreadableLoader::cancel should be called before loader destruction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fileapi/FileReaderLoader.h

Issue 2146403004: ThreadableLoader::cancel should be called before loader destruction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-threadable-loader-client-wrapper

Patch Set: fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp » ('j') | third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fileapi/FileReaderLoader.h

diff --git a/third_party/WebKit/Source/core/fileapi/FileReaderLoader.h b/third_party/WebKit/Source/core/fileapi/FileReaderLoader.h

index 9d5f4533f3c87e6528eb492e78dadbe151d4748a..c1ab823b78dafb85af059c3071747a5b8f48514c 100644

--- a/third_party/WebKit/Source/core/fileapi/FileReaderLoader.h

+++ b/third_party/WebKit/Source/core/fileapi/FileReaderLoader.h

@@ -107,7 +107,6 @@ public:

private:

void startInternal(ExecutionContext&, const Stream*, PassRefPtr<BlobDataHandle>);

- void terminate();

void cleanup();

void failed(FileError::ErrorCode);