Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 2146403002: Kitchen: Generate LogDog prefix from Swarming. (Closed)

Created:
4 years, 5 months ago by dnj
Modified:
4 years, 5 months ago
Reviewers:
dnj (Google), nodir
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Kitchen: Generate LogDog prefix from Swarming. Also bump luci-go: 14b7d6b Milo: Frontpage overall view for buildbot 9e2fdc2 logdog: make MakeStreamName more versatile. fcc9be2 milo: buildbucket builer view 9fcbaf0 Bypass cloud endpoints proxy server on buildbucket cmd line client. 07de3c4 luci-cron: Add 'Abort' button to the job page. 72d9f14 luci-cron: Keep Bootstrap and jQuery closer to the cron source code. BUG=chromium:628321 TEST=None Committed: https://chromium.googlesource.com/infra/infra/+/922db6e6030fd6e5de50ca36da3570840800e3f5

Patch Set 1 : Kitchen: Generate LogDog prefix from Swarming. #

Total comments: 2

Patch Set 2 : LogDog code in same place, address comment. #

Patch Set 3 : Bump DEPS to pick up LogDog API change. #

Patch Set 4 : Fix error strings in tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -50 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M go/src/infra/tools/kitchen/cook.go View 1 4 chunks +4 lines, -40 lines 0 comments Download
M go/src/infra/tools/kitchen/cook_logdog.go View 1 5 chunks +85 lines, -9 lines 0 comments Download
A go/src/infra/tools/kitchen/cook_logdog_test.go View 1 2 3 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
dnj (Google)
PTAL
4 years, 5 months ago (2016-07-14 18:26:59 UTC) #3
nodir
lgtm % better cmdline help https://codereview.chromium.org/2146403002/diff/20001/go/src/infra/tools/kitchen/cook.go File go/src/infra/tools/kitchen/cook.go (right): https://codereview.chromium.org/2146403002/diff/20001/go/src/infra/tools/kitchen/cook.go#newcode90 go/src/infra/tools/kitchen/cook.go:90: "task parameters.") please explain ...
4 years, 5 months ago (2016-07-14 22:25:49 UTC) #4
dnj (Google)
https://codereview.chromium.org/2146403002/diff/20001/go/src/infra/tools/kitchen/cook.go File go/src/infra/tools/kitchen/cook.go (right): https://codereview.chromium.org/2146403002/diff/20001/go/src/infra/tools/kitchen/cook.go#newcode90 go/src/infra/tools/kitchen/cook.go:90: "task parameters.") On 2016/07/14 22:25:48, nodir wrote: > please ...
4 years, 5 months ago (2016-07-14 22:37:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146403002/40001
4 years, 5 months ago (2016-07-14 22:37:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146403002/60001
4 years, 5 months ago (2016-07-15 16:40:11 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Infra Win Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Win%20Tester/builds/3069)
4 years, 5 months ago (2016-07-15 16:52:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146403002/80001
4 years, 5 months ago (2016-07-15 17:11:57 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 17:29:37 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/infra/infra/+/922db6e6030fd6e5de50ca36da357...

Powered by Google App Engine
This is Rietveld 408576698