src/runtime/runtime-internal.cc - Issue 2146353002: [stubs] Properly handle length overflow in StringAddStub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-internal.cc

Issue 2146353002: [stubs] Properly handle length overflow in StringAddStub. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Throw a proper RangeError Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-internal.cc

diff --git a/src/runtime/runtime-internal.cc b/src/runtime/runtime-internal.cc

index 6bc27d4bf42e8f9571bcc7c534c7dffb17661bf6..9f6a4fd7f15c10dc08f2c8d9bfba9c3ba5e49179 100644

--- a/src/runtime/runtime-internal.cc

+++ b/src/runtime/runtime-internal.cc

@@ -230,6 +230,12 @@ RUNTIME_FUNCTION(Runtime_ThrowIncompatibleMethodReceiver) {

NewTypeError(MessageTemplate::kIncompatibleMethodReceiver, arg0, arg1));

}

+RUNTIME_FUNCTION(Runtime_ThrowInvalidStringLength) {

+ HandleScope scope(isolate);

+ THROW_NEW_ERROR_RETURN_FAILURE(

+ isolate, NewRangeError(MessageTemplate::kInvalidStringLength));

RUNTIME_FUNCTION(Runtime_ThrowIteratorResultNotAnObject) {

HandleScope scope(isolate);

DCHECK(args.length() == 1);