[stubs] Properly handle length overflow in StringAddStub.

[stubs] Properly handle length overflow in StringAddStub.

Using the Hydrogen code stub bailout mechanism is not correct for the
string length overflow check in the StringAddStub. Instead make sure we
just throw the proper exception.

R=mstarzinger@chromium.org
BUG=chromium:627934
Committed: https://crrev.com/6530a16eb5b7ccfd4cbcda105035f2c4c27295db
Cr-Commit-Position: refs/heads/master@{#37758}

[Benedikt Meurer, 2016-07-14 11:11:58]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 11:12:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-07-14 11:12:32]

Hey Michi,

Here's the quick fix for the StringAddStub (back-mergable if necessary).
Please take a look.

Thanks,
Benedikt

[Michael Starzinger, 2016-07-14 11:14:20]

LGTM.

https://codereview.chromium.org/2146353002/diff/1/src/runtime/runtime-interna...
File src/runtime/runtime-internal.cc (right):

https://codereview.chromium.org/2146353002/diff/1/src/runtime/runtime-interna...
src/runtime/runtime-internal.cc:234: HandleScope scope(isolate);
nit: DCHECK_EQ(0, args.length());

[Benedikt Meurer, 2016-07-14 11:22:29]

https://codereview.chromium.org/2146353002/diff/1/src/runtime/runtime-interna...
File src/runtime/runtime-internal.cc (right):

https://codereview.chromium.org/2146353002/diff/1/src/runtime/runtime-interna...
src/runtime/runtime-internal.cc:234: HandleScope scope(isolate);
Doesn't matter.

[Benedikt Meurer, 2016-07-14 11:24:08]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-07-14 11:24:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2146353002/#ps20001
(title: "Throw a proper RangeError")

[commit-bot: I haz the power, 2016-07-14 11:24:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 11:44:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-14 11:47:52]

Description was changed from

==========
[stubs] Properly handle length overflow in StringAddStub.

Using the Hydrogen code stub bailout mechanism is not correct for the
string length overflow check in the StringAddStub. Instead make sure we
just throw the proper exception.

R=mstarzinger@chromium.org
BUG=chromium:627934
==========

to

==========
[stubs] Properly handle length overflow in StringAddStub.

Using the Hydrogen code stub bailout mechanism is not correct for the
string length overflow check in the StringAddStub. Instead make sure we
just throw the proper exception.

R=mstarzinger@chromium.org
BUG=chromium:627934

Committed: https://crrev.com/6530a16eb5b7ccfd4cbcda105035f2c4c27295db
Cr-Commit-Position: refs/heads/master@{#37758}
==========

[commit-bot: I haz the power, 2016-07-14 11:47:52]

Patchset 2 (id:??) landed as
https://crrev.com/6530a16eb5b7ccfd4cbcda105035f2c4c27295db
Cr-Commit-Position: refs/heads/master@{#37758}

[jgruber, 2017-01-31 15:13:46]

jgruber@chromium.org changed reviewers:
+ jgruber@chromium.org

[jgruber, 2017-01-31 15:13:47]

https://codereview.chromium.org/2146353002/diff/20001/src/crankshaft/hydrogen.cc
File src/crankshaft/hydrogen.cc (right):

https://codereview.chromium.org/2146353002/diff/20001/src/crankshaft/hydrogen...
src/crankshaft/hydrogen.cc:2418: // will be to migrate the StringAddStub to
TurboFan one day.
FYI: We now have a TF StringAddStub. Not sure from the description if we can
simply remove this branch? The test from this CL passes.

[Benedikt Meurer, 2017-01-31 17:57:20]

https://codereview.chromium.org/2146353002/diff/20001/src/crankshaft/hydrogen.cc
File src/crankshaft/hydrogen.cc (right):

https://codereview.chromium.org/2146353002/diff/20001/src/crankshaft/hydrogen...
src/crankshaft/hydrogen.cc:2418: // will be to migrate the StringAddStub to
TurboFan one day.
I think we still inline this into the BinaryOpIC for String addition, so for now
just keep it.