Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2146333004: move responsibility for creating raster-device into pdf (Closed)

Created:
4 years, 5 months ago by reed1
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

move responsibility for creating raster-device into pdf BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146333004 NOTRY=True win failure seems unrelated Committed: https://skia.googlesource.com/skia/+/7503d60847c4ad22df87458aecd917772b23d293

Patch Set 1 #

Total comments: 2

Patch Set 2 : ptal #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M include/core/SkCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 1 2 8 chunks +8 lines, -23 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 2 3 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
reed1
4 years, 5 months ago (2016-07-15 15:02:43 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/2146333004/diff/1/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): https://codereview.chromium.org/2146333004/diff/1/src/pdf/SkPDFDevice.cpp#newcode544 src/pdf/SkPDFDevice.cpp:544: Move this to the top ?
4 years, 5 months ago (2016-07-15 15:07:22 UTC) #6
reed1
https://codereview.chromium.org/2146333004/diff/1/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): https://codereview.chromium.org/2146333004/diff/1/src/pdf/SkPDFDevice.cpp#newcode544 src/pdf/SkPDFDevice.cpp:544: On 2016/07/15 15:07:22, robertphillips wrote: > Move this to ...
4 years, 5 months ago (2016-07-15 16:46:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146333004/40001
4 years, 5 months ago (2016-07-15 21:22:36 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 21:23:33 UTC) #19
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/7503d60847c4ad22df87458aecd917772b23d293

Powered by Google App Engine
This is Rietveld 408576698