Issue 214633002: FlameChart: vertical scroll implementation

Issue 214633002: FlameChart: vertical scroll implementation (Closed)

Created:
6 years, 9 months ago by loislo

Modified:
6 years, 9 months ago

Reviewers:
alph, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

FlameChart: vertical scroll implementation BUG= R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170177

Patch Set 1 #

Total comments: 3

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -17 lines)			Patch
	M	Source/devtools/front_end/FlameChart.js	View		8 chunks	+31 lines, -17 lines	3 comments	Download
	M	Source/devtools/front_end/flameChart.css	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/214633002/diff/1/Source/devtools/front_end/FlameChart.js File Source/devtools/front_end/FlameChart.js (right): https://codereview.chromium.org/214633002/diff/1/Source/devtools/front_end/FlameChart.js#newcode449 Source/devtools/front_end/FlameChart.js:449: this._vScrollElement.scrollTop += -e.wheelDeltaY / 120 * this._offsetHeight / ...

6 years, 9 months ago (2014-03-27 12:48:03 UTC) #2

alph

https://codereview.chromium.org/214633002/diff/1/Source/devtools/front_end/FlameChart.js File Source/devtools/front_end/FlameChart.js (right): https://codereview.chromium.org/214633002/diff/1/Source/devtools/front_end/FlameChart.js#newcode449 Source/devtools/front_end/FlameChart.js:449: this._vScrollElement.scrollTop += -e.wheelDeltaY / 120 * this._offsetHeight / 8; ...

6 years, 9 months ago (2014-03-27 13:15:35 UTC) #3

loislo

6 years, 9 months ago (2014-03-27 13:33:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r170177 (presubmit successful).

Expand Messages | Collapse Messages