Expose RTF content on the clipboard as strings to pages when pasting.

Expose RTF content on the clipboard as strings to pages when pasting.

BUG=317807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/4d8435dc86f802e3416ad1ccc67d0c729c38fe6d
Cr-Commit-Position: refs/heads/master@{#407039}

[dominicc (has gone to gerrit), 2016-07-20 04:35:07]

Description was changed from

==========
Expose RTF content on the clipboard as strings to pages when pasting.

BUG=317807
==========

to

==========
Expose RTF content on the clipboard as strings to pages when pasting.

BUG=317807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[dominicc (has gone to gerrit), 2016-07-20 04:35:20]

The CQ bit was checked by dominicc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 04:35:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominicc (has gone to gerrit), 2016-07-20 04:37:53]

dominicc@chromium.org changed reviewers:
+ dcheng@chromium.org, jochen@chromium.org

[commit-bot: I haz the power, 2016-07-20 06:13:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 06:13:56]

Dry run: This issue passed the CQ dry run.

[dominicc (has gone to gerrit), 2016-07-20 06:39:15]

PTAL

[dcheng, 2016-07-20 07:02:17]

https://codereview.chromium.org/2146323002/diff/40001/content/public/test/bro...
File content/public/test/browser_test_utils.cc (right):

https://codereview.chromium.org/2146323002/diff/40001/content/public/test/bro...
content/public/test/browser_test_utils.cc:1438:
BrowserTestClipboard::BrowserTestClipboard() : is_installed_(false) {}
Nit: let's just merge SetUp and TearDown into the ctor / dtor and call this
BrowserTestClipboardScope or something.

https://codereview.chromium.org/2146323002/diff/40001/content/public/test/bro...
content/public/test/browser_test_utils.cc:1494: base::Unretained(this), text));
Hmm... what a mess. I guess I need to clean up the test abstraction a bit
more...

Can you file a bug and TODO(dcheng) this with a comment like:
"Make the test clipboard on different threads share the same backing store."

https://codereview.chromium.org/2146323002/diff/40001/content/test/data/paste...
File content/test/data/paste_listener.html (right):

https://codereview.chromium.org/2146323002/diff/40001/content/test/data/paste...
content/test/data/paste_listener.html:5: document.body.addEventListener('paste',
(event) => {
Apparently I don't know JS^WES6.

[dominicc (has gone to gerrit), 2016-07-20 08:12:58]

The CQ bit was checked by dominicc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 08:13:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-07-20 11:09:47]

deferring to dcheng

[commit-bot: I haz the power, 2016-07-20 11:36:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 11:36:31]

Dry run: This issue passed the CQ dry run.

[dominicc (has gone to gerrit), 2016-07-21 01:31:52]

PTAL

Removed the Unretained; these callbacks don't need state. Still a mare's nest of
ifdefs though.

[dcheng, 2016-07-21 02:35:55]

LGTM from the clipboard perspective. Thanks!

[dominicc (has gone to gerrit), 2016-07-21 08:22:11]

On 2016/07/21 at 02:35:55, dcheng wrote:
> LGTM from the clipboard perspective. Thanks!

Thanks. jochen, could you OWNERS approve this, or should I hunt more specific
owners?

[jochen (gone - plz use gerrit), 2016-07-21 08:30:53]

lgtm

[dominicc (has gone to gerrit), 2016-07-22 00:56:50]

The CQ bit was checked by dominicc@chromium.org

[commit-bot: I haz the power, 2016-07-22 00:57:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 03:43:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-22 03:46:17]

Description was changed from

==========
Expose RTF content on the clipboard as strings to pages when pasting.

BUG=317807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Expose RTF content on the clipboard as strings to pages when pasting.

BUG=317807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/4d8435dc86f802e3416ad1ccc67d0c729c38fe6d
Cr-Commit-Position: refs/heads/master@{#407039}
==========

[commit-bot: I haz the power, 2016-07-22 03:46:18]

Patchset 4 (id:??) landed as
https://crrev.com/4d8435dc86f802e3416ad1ccc67d0c729c38fe6d
Cr-Commit-Position: refs/heads/master@{#407039}