Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2146313005: Count the SetOutputNodeVolume requests sent during the audio initialization and track them with the… (Closed)

Created:
4 years, 5 months ago by jennyz
Modified:
4 years, 5 months ago
Reviewers:
hychao
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Count the SetOutputNodeVolume requests sent during the audio initialization and track them with the OutputNodeVolumeChanged signals responding from cras, do not pop up the volume bar for such signals. BUG=625222 Committed: https://crrev.com/e7818501bc53a0f764221189ad2fcf9c7c101fac Cr-Commit-Position: refs/heads/master@{#406014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M chromeos/audio/cras_audio_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/audio/cras_audio_handler.cc View 2 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jennyz
After your change in cras for always sending OutputNodeVolumeChanged signal for all set volume requests, ...
4 years, 5 months ago (2016-07-15 18:42:26 UTC) #1
jennyz
4 years, 5 months ago (2016-07-15 18:42:51 UTC) #4
hychao
lgtm
4 years, 5 months ago (2016-07-18 15:43:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146313005/1
4 years, 5 months ago (2016-07-18 15:44:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 16:51:19 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 16:54:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7818501bc53a0f764221189ad2fcf9c7c101fac
Cr-Commit-Position: refs/heads/master@{#406014}

Powered by Google App Engine
This is Rietveld 408576698