src/compiler/code-assembler.h - Issue 2146293003: [builtins] implement Array.prototype.includes in TurboFan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/code-assembler.h

Issue 2146293003: [builtins] implement Array.prototype.includes in TurboFan (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add a basic impl in ElementsAccessor, cleanup %ArrayIncludes_Slow, lots of new tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/code-assembler.h

diff --git a/src/compiler/code-assembler.h b/src/compiler/code-assembler.h

index b05dc1ac7b8e43474bdf0fce283da3a39b3fec3b..2ea17a5988754f576c118272ffa954679f32e00f 100644

--- a/src/compiler/code-assembler.h

+++ b/src/compiler/code-assembler.h

@@ -245,7 +245,7 @@ class CodeAssembler {

void GotoUnless(Node* condition, Label* false_label);

void Branch(Node* condition, Label* true_label, Label* false_label);

- void Switch(Node* index, Label* default_label, int32_t* case_values,

+ void Switch(Node* index, Label* default_label, const int32_t* case_values,

Label** case_labels, size_t case_count);

Node* Select(Node* condition, Node* true_value, Node* false_value,