Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: src/builtins/builtins.cc

Issue 2146293003: [builtins] implement Array.prototype.includes in TurboFan (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Refactor based on bmeurer comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins/builtins.h" 5 #include "src/builtins/builtins.h"
6 6
7 #include "src/api-arguments.h" 7 #include "src/api-arguments.h"
8 #include "src/api-natives.h" 8 #include "src/api-natives.h"
9 #include "src/api.h" 9 #include "src/api.h"
10 #include "src/base/ieee754.h" 10 #include "src/base/ieee754.h"
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 assembler->Return(assembler->BooleanConstant(true)); 336 assembler->Return(assembler->BooleanConstant(true));
337 337
338 assembler->Bind(&return_false); 338 assembler->Bind(&return_false);
339 assembler->Return(assembler->BooleanConstant(false)); 339 assembler->Return(assembler->BooleanConstant(false));
340 340
341 assembler->Bind(&call_runtime); 341 assembler->Bind(&call_runtime);
342 assembler->Return( 342 assembler->Return(
343 assembler->CallRuntime(Runtime::kArrayIsArray, context, object)); 343 assembler->CallRuntime(Runtime::kArrayIsArray, context, object));
344 } 344 }
345 345
346 void Builtins::Generate_ArrayIncludes(CodeStubAssembler* assembler) {
347 typedef compiler::Node Node;
348 typedef CodeStubAssembler::Label Label;
349 typedef CodeStubAssembler::Variable Variable;
350
351 Node* array = assembler->Parameter(0);
352 Node* search_element = assembler->Parameter(1);
353 Node* start_from = assembler->Parameter(2);
354 Node* context = assembler->Parameter(3 + 2);
355
356 Node* int32_zero = assembler->Int32Constant(0);
357 Node* int32_one = assembler->Int32Constant(1);
358
359 Variable len(assembler, MachineRepresentation::kWord32),
360 k(assembler, MachineRepresentation::kWord32),
361 n(assembler, MachineRepresentation::kWord32);
362
363 Label init_k(assembler), return_true(assembler), return_false(assembler),
364 call_runtime(assembler);
365
366 { // Prologue
367 // 1. Bailout to slow path if `array` is not a JSArray
368 assembler->GotoIf(assembler->WordIsSmi(array), &call_runtime);
369 Node* instance_type = assembler->LoadInstanceType(array);
370 assembler->GotoUnless(
371 assembler->Word32Equal(instance_type,
372 assembler->Int32Constant(JS_ARRAY_TYPE)),
373 &call_runtime);
374
375 // 2. Bailout to slow path if elements kind is not fast
376 Node* map = assembler->LoadMap(array);
377 Node* bit_field2 = assembler->LoadMapBitField2(map);
378 Node* elements_kind =
379 assembler->BitFieldDecode<Map::ElementsKindBits>(bit_field2);
380 // assembler->DebugBreak();
381 assembler->GotoIf(
382 assembler->Int32GreaterThan(
383 elements_kind, assembler->Int32Constant(LAST_FAST_ELEMENTS_KIND)),
384 &call_runtime);
385
386 // 3. Bailout to slow path if array protector field invalid
387 assembler->GotoUnless(
388 assembler->WordEqual(
389 assembler->LoadObjectField(
390 assembler->LoadRoot(Heap::kArrayProtectorRootIndex),
391 PropertyCell::kValueOffset),
392 assembler->SmiConstant(
393 Smi::FromInt(Isolate::kArrayProtectorValid))),
394 &call_runtime);
395
396 len.Bind(assembler->SmiToWord(
397 assembler->LoadObjectField(array, JSArray::kLengthOffset)));
398 assembler->GotoUnless(assembler->Word32Equal(len.value(), int32_zero),
399 &init_k);
400 assembler->Return(assembler->BooleanConstant(false));
401 }
402
403 assembler->Bind(&init_k);
404 {
405 Variable tagged_n(assembler, MachineRepresentation::kTagged);
406 Label done(assembler), if_neg(assembler), init_k_smi(assembler),
407 init_k_zero(assembler);
408 Callable call_to_integer = CodeFactory::ToInteger(assembler->isolate());
409 tagged_n.Bind(assembler->CallStub(call_to_integer, context, start_from));
410
411 assembler->GotoIf(assembler->WordIsSmi(tagged_n.value()), &init_k_smi);
412
413 Node* fp_len = assembler->ChangeInt32ToFloat64(len.value());
414 Node* fp_n = assembler->TruncateTaggedToFloat64(context, tagged_n.value());
415
416 assembler->GotoIf(assembler->Float64GreaterThanOrEqual(fp_n, fp_len),
417 &return_false);
418
419 tagged_n.Bind(
420 assembler->SmiFromWord32(assembler->TruncateFloat64ToWord32(fp_n)));
421
422 assembler->Goto(&init_k_smi);
423 assembler->Bind(&init_k_smi);
424 n.Bind(assembler->SmiToWord32(tagged_n.value()));
425
426 assembler->GotoUnless(
427 assembler->Int32GreaterThanOrEqual(n.value(), int32_zero), &if_neg);
428 k.Bind(n.value());
429 assembler->Goto(&done);
430
431 assembler->Bind(&if_neg);
432 k.Bind(assembler->Int32Add(len.value(), n.value()));
433 assembler->BranchIf(assembler->Int32LessThan(k.value(), int32_zero),
434 &init_k_zero, &done);
435
436 assembler->Bind(&init_k_zero);
437 k.Bind(int32_zero);
438
439 assembler->Goto(&done);
440 assembler->Bind(&done);
441 }
442
443 { // Repeat while k < len
444 Variable element_k(assembler, MachineRepresentation::kTagged);
445 Variable stable(assembler, MachineRepresentation::kWord32);
446
447 Variable* loop_body_variables[] = {&k, &stable};
448
449 Label loop_body(assembler, 2,
450 static_cast<Variable **>(loop_body_variables)),
451 continue_loop(assembler), if_issmiorobject(assembler),
452 if_isdouble(assembler), if_slowpath(assembler), test_element(assembler);
453
454 stable.Bind(int32_one);
455 Node* map = assembler->LoadMap(array);
456 Node* bit_field2 = assembler->LoadMapBitField2(map);
457 Node* elements_kind =
458 assembler->BitFieldDecode<Map::ElementsKindBits>(bit_field2);
459
460 assembler->Goto(&loop_body);
461 assembler->Bind(&loop_body);
462
463 assembler->GotoUnless(assembler->Uint32LessThan(k.value(), len.value()),
464 &return_false);
465
466 assembler->GotoIf(assembler->WordEqual(stable.value(), int32_zero),
467 &if_slowpath);
468
469 assembler->Branch(
470 assembler->Int32LessThan(
471 elements_kind, assembler->Int32Constant(FAST_DOUBLE_ELEMENTS)),
472 &if_issmiorobject, &if_isdouble);
473
474 assembler->Bind(&if_issmiorobject);
475 { // Fast Smi/Object elements
476 Node* elements = assembler->LoadElements(array);
477 Node* length = assembler->LoadFixedArrayBaseLength(elements);
478
479 assembler->GotoUnless(
480 assembler->Int32LessThan(k.value(), assembler->SmiToWord32(length)),
481 &if_slowpath);
482
483 Node* element = assembler->LoadFixedArrayElement(elements, k.value());
484 Node* the_hole = assembler->TheHoleConstant();
485
486 assembler->GotoUnless(assembler->WordNotEqual(element, the_hole),
487 &if_slowpath);
488 element_k.Bind(element);
489 assembler->Goto(&test_element);
490 }
491
492 assembler->Bind(&if_isdouble);
493 { // Fast double elements
494 Node* elements = assembler->LoadElements(array);
495 Node* length = assembler->LoadFixedArrayBaseLength(elements);
496
497 assembler->GotoUnless(
498 assembler->Int32LessThan(k.value(), assembler->SmiToWord32(length)),
499 &if_slowpath);
500
501 if (kPointerSize == kDoubleSize) {
502 Node* element = assembler->LoadFixedDoubleArrayElement(
503 elements, k.value(), MachineType::Uint64());
504 Node* the_hole = assembler->Int64Constant(kHoleNanInt64);
505 assembler->GotoIf(assembler->Word64Equal(element, the_hole),
506 &if_slowpath);
507 } else {
508 Node* element_upper = assembler->LoadFixedDoubleArrayElement(
509 elements, k.value(), MachineType::Uint32(),
510 kIeeeDoubleExponentWordOffset);
511 assembler->GotoIf(
512 assembler->Word32Equal(element_upper,
513 assembler->Int32Constant(kHoleNanUpper32)),
514 &if_slowpath);
515 }
516
517 Node* element = assembler->LoadFixedDoubleArrayElement(
518 elements, k.value(), MachineType::Float64());
519 element_k.Bind(assembler->AllocateHeapNumberWithValue(element));
520 assembler->Goto(&test_element);
521 }
522
523 assembler->Bind(&if_slowpath);
524 {
525 Node* element =
526 assembler->CallRuntime(Runtime::kGetProperty, context, array,
527 assembler->SmiFromWord32(k.value()));
528 element_k.Bind(element);
529
530 // Slow path may have modified elements backing store in some way.
531 assembler->GotoIf(assembler->WordEqual(stable.value(), int32_zero),
532 &test_element);
533 Node* current_map = assembler->LoadMap(array);
534 assembler->GotoIf(assembler->WordEqual(map, current_map), &test_element);
535 stable.Bind(int32_zero);
536 assembler->Goto(&test_element);
537 }
538
539 assembler->Bind(&test_element);
540 assembler->BranchIfSameValueZero(search_element, element_k.value(), context,
541 &return_true, &continue_loop);
542
543 assembler->Bind(&continue_loop);
544 k.Bind(assembler->Int32Add(k.value(), int32_one));
545 assembler->Goto(&loop_body);
546 }
547
548 assembler->Bind(&return_true);
549 assembler->Return(assembler->BooleanConstant(true));
550
551 assembler->Bind(&return_false);
552 assembler->Return(assembler->BooleanConstant(false));
553
554 assembler->Bind(&call_runtime);
555 assembler->Return(assembler->CallRuntime(Runtime::kArrayIncludes_Slow,
556 context, array, search_element,
557 start_from));
558 }
559
346 void Builtins::Generate_ObjectHasOwnProperty(CodeStubAssembler* assembler) { 560 void Builtins::Generate_ObjectHasOwnProperty(CodeStubAssembler* assembler) {
347 typedef compiler::Node Node; 561 typedef compiler::Node Node;
348 typedef CodeStubAssembler::Label Label; 562 typedef CodeStubAssembler::Label Label;
349 typedef CodeStubAssembler::Variable Variable; 563 typedef CodeStubAssembler::Variable Variable;
350 564
351 Node* object = assembler->Parameter(0); 565 Node* object = assembler->Parameter(0);
352 Node* key = assembler->Parameter(1); 566 Node* key = assembler->Parameter(1);
353 Node* context = assembler->Parameter(4); 567 Node* context = assembler->Parameter(4);
354 568
355 Label call_runtime(assembler), return_true(assembler), 569 Label call_runtime(assembler), return_true(assembler),
(...skipping 6469 matching lines...) Expand 10 before | Expand all | Expand 10 after
6825 #define DEFINE_BUILTIN_ACCESSOR(Name, ...) \ 7039 #define DEFINE_BUILTIN_ACCESSOR(Name, ...) \
6826 Handle<Code> Builtins::Name() { \ 7040 Handle<Code> Builtins::Name() { \
6827 Code** code_address = reinterpret_cast<Code**>(builtin_address(k##Name)); \ 7041 Code** code_address = reinterpret_cast<Code**>(builtin_address(k##Name)); \
6828 return Handle<Code>(code_address); \ 7042 return Handle<Code>(code_address); \
6829 } 7043 }
6830 BUILTIN_LIST_ALL(DEFINE_BUILTIN_ACCESSOR) 7044 BUILTIN_LIST_ALL(DEFINE_BUILTIN_ACCESSOR)
6831 #undef DEFINE_BUILTIN_ACCESSOR 7045 #undef DEFINE_BUILTIN_ACCESSOR
6832 7046
6833 } // namespace internal 7047 } // namespace internal
6834 } // namespace v8 7048 } // namespace v8
OLDNEW
« no previous file with comments | « src/builtins/builtins.h ('k') | src/code-stub-assembler.h » ('j') | src/code-stub-assembler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698