Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: src/code-stub-assembler.cc

Issue 2146293003: [builtins] implement Array.prototype.includes in TurboFan (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add a basic impl in ElementsAccessor, cleanup %ArrayIncludes_Slow, lots of new tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-stub-assembler.h" 5 #include "src/code-stub-assembler.h"
6 #include "src/code-factory.h" 6 #include "src/code-factory.h"
7 #include "src/frames-inl.h" 7 #include "src/frames-inl.h"
8 #include "src/frames.h" 8 #include "src/frames.h"
9 #include "src/ic/stub-cache.h" 9 #include "src/ic/stub-cache.h"
10 10
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 464
465 Node* CodeStubAssembler::WordIsSmi(Node* a) { 465 Node* CodeStubAssembler::WordIsSmi(Node* a) {
466 return WordEqual(WordAnd(a, IntPtrConstant(kSmiTagMask)), IntPtrConstant(0)); 466 return WordEqual(WordAnd(a, IntPtrConstant(kSmiTagMask)), IntPtrConstant(0));
467 } 467 }
468 468
469 Node* CodeStubAssembler::WordIsPositiveSmi(Node* a) { 469 Node* CodeStubAssembler::WordIsPositiveSmi(Node* a) {
470 return WordEqual(WordAnd(a, IntPtrConstant(kSmiTagMask | kSmiSignMask)), 470 return WordEqual(WordAnd(a, IntPtrConstant(kSmiTagMask | kSmiSignMask)),
471 IntPtrConstant(0)); 471 IntPtrConstant(0));
472 } 472 }
473 473
474 void CodeStubAssembler::BranchIfSameValueZero(Node* a, Node* b, Node* context,
caitp 2016/07/21 03:28:55 this isn't really used in the TF implementation cu
475 Label* if_true, Label* if_false) {
476 Node* number_map = HeapNumberMapConstant();
477 Label a_isnumber(this), a_isnotnumber(this), b_isnumber(this), a_isnan(this),
478 float_not_equal(this);
479 // If register A and register B are identical, goto `if_true`
480 GotoIf(WordEqual(a, b), if_true);
481 // If either register A or B are Smis, goto `if_false`
482 GotoIf(Word32Or(WordIsSmi(a), WordIsSmi(b)), if_false);
483 // GotoIf(WordIsSmi(b), if_false);
484
485 Node* a_map = LoadMap(a);
486 Node* b_map = LoadMap(b);
487 Branch(WordEqual(a_map, number_map), &a_isnumber, &a_isnotnumber);
488
489 // If both register A and B are HeapNumbers, return true if they are equal,
490 // or if both are NaN
491 Bind(&a_isnumber);
492 {
493 Branch(WordEqual(b_map, number_map), &b_isnumber, if_false);
494
495 Bind(&b_isnumber);
496 Node* a_value = LoadHeapNumberValue(a);
497 Node* b_value = LoadHeapNumberValue(b);
498 BranchIfFloat64Equal(a_value, b_value, if_true, &float_not_equal);
499
500 Bind(&float_not_equal);
501 BranchIfFloat64IsNaN(a_value, &a_isnan, if_false);
502
503 Bind(&a_isnan);
504 BranchIfFloat64IsNaN(a_value, if_true, if_false);
505 }
506
507 Bind(&a_isnotnumber);
508 {
509 Label a_isstring(this), a_isnotstring(this);
510 Node* a_instance_type = LoadMapInstanceType(a_map);
511
512 Branch(Int32LessThan(a_instance_type, Int32Constant(FIRST_NONSTRING_TYPE)),
513 &a_isstring, &a_isnotstring);
514
515 Bind(&a_isstring);
516 {
517 Label b_isstring(this), b_isnotstring(this);
518 Node* b_instance_type = LoadInstanceType(b_map);
519
520 Branch(
521 Int32LessThan(b_instance_type, Int32Constant(FIRST_NONSTRING_TYPE)),
522 &b_isstring, if_false);
523
524 Bind(&b_isstring);
525 {
526 Callable callable = CodeFactory::StringEqual(isolate());
527 Node* result = CallStub(callable, context, a, b);
528 Branch(WordEqual(BooleanConstant(true), result), if_true, if_false);
529 }
530 }
531
532 Bind(&a_isnotstring);
533 {
534 // Check if {lhs} is a Simd128Value.
535 Label a_issimd128value(this);
536 Branch(Word32Equal(a_instance_type, Int32Constant(SIMD128_VALUE_TYPE)),
537 &a_issimd128value, if_false);
538
539 Bind(&a_issimd128value);
540 {
541 // Load the map of {rhs}.
542 BranchIfSimd128Equal(a, a_map, b, b_map, if_true, if_false);
543 }
544 }
545 }
546 }
547
548 void CodeStubAssembler::BranchIfSimd128Equal(Node* a, Node* a_map, Node* b,
549 Node* b_map, Label* if_true,
550 Label* if_false) {
551 Label if_mapsame(this);
552
553 Node* simd128_value_type = Int32Constant(SIMD128_VALUE_TYPE);
554 Assert(Word32Equal(LoadMapInstanceType(a_map), simd128_value_type));
555
556 Branch(Word32Equal(LoadMapInstanceType(b_map), simd128_value_type),
557 &if_mapsame, if_false);
558
559 Bind(&if_mapsame);
560 {
561 Label if_float32x4(this), if_notfloat32x4(this);
562 Node* float32x4_map = HeapConstant(factory()->float32x4_map());
563 Branch(WordEqual(a_map, float32x4_map), &if_float32x4, &if_notfloat32x4);
564
565 Bind(&if_float32x4);
566 {
567 for (int offset = Float32x4::kValueOffset - kHeapObjectTag;
568 offset < Float32x4::kSize - kHeapObjectTag;
569 offset += sizeof(float)) {
570 // Load the floating point values for {lhs} and {rhs}.
571 Node* a_value = Load(MachineType::Float32(), a, IntPtrConstant(offset));
572 Node* b_value = Load(MachineType::Float32(), b, IntPtrConstant(offset));
573
574 // Perform a floating point comparison.
575 Label if_valueequal(this);
576 Branch(Float32Equal(a_value, b_value), &if_valueequal, if_false);
577 Bind(&if_valueequal);
578 }
579 Goto(if_true);
580 }
581
582 Bind(&if_notfloat32x4);
583 {
584 // For other Simd128Values we just perform a bitwise comparison.
585 for (int offset = Simd128Value::kValueOffset - kHeapObjectTag;
586 offset < Simd128Value::kSize - kHeapObjectTag;
587 offset += kPointerSize) {
588 // Load the word values for {lhs} and {rhs}.
589 Node* a_value = Load(MachineType::Pointer(), a, IntPtrConstant(offset));
590 Node* b_value = Load(MachineType::Pointer(), b, IntPtrConstant(offset));
591
592 // Perform a bitwise word-comparison.
593 Label if_valueequal(this);
594 Branch(WordEqual(a_value, b_value), &if_valueequal, if_false);
595 Bind(&if_valueequal);
596 }
597
598 // Bitwise comparison succeeded, {lhs} and {rhs} considered equal.
599 Goto(if_true);
600 }
601 }
602 }
603
604 void CodeStubAssembler::BranchIfFastJSArray(Node* object, Node* context,
605 Label* if_true, Label* if_false) {
606 Node* int32_zero = Int32Constant(0);
607 Node* int32_one = Int32Constant(1);
608
609 Node* empty_elements = LoadRoot(Heap::kEmptyFixedArrayRootIndex);
610
611 Variable last_map(this, MachineRepresentation::kTagged);
612 Label check_prototype(this);
613
614 // Bailout if Smi
615 GotoIf(WordIsSmi(object), if_false);
616
617 Node* map = LoadMap(object);
618 last_map.Bind(map);
619
620 // Bailout if instance type is not JS_ARRAY_TYPE
621 GotoIf(WordNotEqual(LoadMapInstanceType(map), Int32Constant(JS_ARRAY_TYPE)),
622 if_false);
623
624 Node* bit_field2 = LoadMapBitField2(map);
625 Node* elements_kind = BitFieldDecode<Map::ElementsKindBits>(bit_field2);
626
627 // Bailout if slow receiver elements
628 GotoIf(
629 Int32GreaterThan(elements_kind, Int32Constant(LAST_FAST_ELEMENTS_KIND)),
630 if_false);
631
632 STATIC_ASSERT(FAST_HOLEY_SMI_ELEMENTS == (FAST_SMI_ELEMENTS | 1));
633 STATIC_ASSERT(FAST_HOLEY_ELEMENTS == (FAST_ELEMENTS | 1));
634 STATIC_ASSERT(FAST_HOLEY_DOUBLE_ELEMENTS == (FAST_DOUBLE_ELEMENTS | 1));
635
636 // Check prototype chain if receiver does not have packed elements
637 Node* holey_elements = Word32And(elements_kind, int32_one);
638 Branch(Word32Equal(holey_elements, int32_zero), if_true, &check_prototype);
639
640 Bind(&check_prototype);
641 {
642 Label loop_body(this, &last_map);
643 Goto(&loop_body);
644 Bind(&loop_body);
645 Node* current_map = last_map.value();
646 Node* proto = LoadObjectField(current_map, Map::kPrototypeOffset);
647
648 // End loop
649 GotoIf(WordEqual(proto, NullConstant()), if_true);
650
651 // ASSERT: proto->IsHeapObject()
652 Node* proto_map = LoadMap(proto);
653
654 // Bailout if a Proxy, API Object, or JSValue wrapper found in prototype
655 // Because of this bailout, it's not necessary to check for interceptors or
656 // access checks on the prototype chain.
657 GotoIf(Int32LessThanOrEqual(LoadMapInstanceType(proto_map),
caitp 2016/07/21 03:28:55 Updated to avoid the interceptors/access check tes
658 Int32Constant(LAST_CUSTOM_ELEMENTS_RECEIVER)),
659 if_false);
660
661 // Bailout if prototype contains non-empty elements
662 GotoUnless(WordEqual(LoadElements(proto), empty_elements), if_false);
caitp 2016/07/21 03:28:55 Updated to point to the empty fixed array
663
664 last_map.Bind(proto_map);
665 Goto(&loop_body);
666 }
667 }
668
474 Node* CodeStubAssembler::AllocateRawUnaligned(Node* size_in_bytes, 669 Node* CodeStubAssembler::AllocateRawUnaligned(Node* size_in_bytes,
475 AllocationFlags flags, 670 AllocationFlags flags,
476 Node* top_address, 671 Node* top_address,
477 Node* limit_address) { 672 Node* limit_address) {
478 Node* top = Load(MachineType::Pointer(), top_address); 673 Node* top = Load(MachineType::Pointer(), top_address);
479 Node* limit = Load(MachineType::Pointer(), limit_address); 674 Node* limit = Load(MachineType::Pointer(), limit_address);
480 675
481 // If there's not enough space, call the runtime. 676 // If there's not enough space, call the runtime.
482 Variable result(this, MachineRepresentation::kTagged); 677 Variable result(this, MachineRepresentation::kTagged);
483 Label runtime_call(this, Label::kDeferred), no_runtime_call(this); 678 Label runtime_call(this, Label::kDeferred), no_runtime_call(this);
(...skipping 2575 matching lines...) Expand 10 before | Expand all | Expand 10 after
3059 } 3254 }
3060 Bind(&miss); 3255 Bind(&miss);
3061 { 3256 {
3062 TailCallRuntime(Runtime::kLoadGlobalIC_Miss, p->context, p->slot, 3257 TailCallRuntime(Runtime::kLoadGlobalIC_Miss, p->context, p->slot,
3063 p->vector); 3258 p->vector);
3064 } 3259 }
3065 } 3260 }
3066 3261
3067 } // namespace internal 3262 } // namespace internal
3068 } // namespace v8 3263 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698