Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2341)

Unified Diff: chrome/browser/password_manager/credential_manager_browsertest.cc

Issue 2146263002: Disable test made flaky by DCHECK() on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/credential_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/credential_manager_browsertest.cc b/chrome/browser/password_manager/credential_manager_browsertest.cc
index 84792c6f49fea6686fc0d15dca71043ee7cf2209..d9fc7fe4d8ef7c4fc3c33d84d0b9443e66c41038 100644
--- a/chrome/browser/password_manager/credential_manager_browsertest.cc
+++ b/chrome/browser/password_manager/credential_manager_browsertest.cc
@@ -81,8 +81,16 @@ IN_PROC_BROWSER_TEST_F(CredentialManagerBrowserTest,
EXPECT_FALSE(form.skip_zero_click);
}
+// TODO(crbug.com/626759): flakily failing on Mac.
+#if defined(OS_MACOSX)
+#define MAYBE_AutoSigninOldCredentialAndNavigation \
+ DISABLED_AutoSigninOldCredentialAndNavigation
+#else
+#define MAYBE_AutoSigninOldCredentialAndNavigation \
+ AutoSigninOldCredentialAndNavigation
+#endif
IN_PROC_BROWSER_TEST_F(CredentialManagerBrowserTest,
- AutoSigninOldCredentialAndNavigation) {
+ MAYBE_AutoSigninOldCredentialAndNavigation) {
// Save credentials with 'skip_zero_click' false.
scoped_refptr<password_manager::TestPasswordStore> password_store =
static_cast<password_manager::TestPasswordStore*>(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698