Issue 214623002: Only allow automatic FrameScope types for FrameAndConstantPoolScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 214623002: Only allow automatic FrameScope types for FrameAndConstantPoolScope (Closed)

Created:
6 years, 9 months ago by rmcilroy

Modified:
6 years, 8 months ago

Reviewers:
ulan

CC:
v8-dev, Alexandre Rames

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Only allow automatic FrameScope types for FrameAndConstantPoolScope In certain situations the PP register would be invalid in a FrameScope::Manual FrameAndConstantPoolScope R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20387

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -7 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

rmcilroy

I found some bugs in non-automatic FrameAndConstantPoolScopes - I think it's best just to disallow ...

6 years, 9 months ago (2014-03-27 12:21:34 UTC) #2

rmcilroy

6 years, 8 months ago (2014-04-01 10:50:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r20387 (presubmit successful).