Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2146223003: Remove GrWrapTextureInBitmap call in SkGpuDevice::drawSpriteWithFilter (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove GrWrapTextureInBitmap call in SkGpuDevice::drawSpriteWithFilter BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146223003 Committed: https://skia.googlesource.com/skia/+/970587bf0ed73807632be7b0f349a96995cee4ec

Patch Set 1 #

Total comments: 1

Patch Set 2 : update #

Patch Set 3 : update #

Patch Set 4 : update API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -61 lines) Patch
M src/gpu/SkGpuDevice.h View 1 2 3 4 chunks +13 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 3 chunks +86 lines, -59 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
robertphillips
It isn't quite ready to go (still some drawing errors) but this is the general ...
4 years, 5 months ago (2016-07-14 17:08:55 UTC) #4
bsalomon
https://codereview.chromium.org/2146223003/diff/1/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/2146223003/diff/1/src/gpu/SkGpuDevice.cpp#newcode1250 src/gpu/SkGpuDevice.cpp:1250: sk_sp<GrTexture> texture = sk_ref_sp(bitmap.getTexture()); I think I'm missing something. ...
4 years, 5 months ago (2016-07-14 17:19:34 UTC) #5
robertphillips
All right, PTAL for real
4 years, 5 months ago (2016-07-14 20:09:17 UTC) #6
bsalomon
lgtm
4 years, 5 months ago (2016-07-14 20:24:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146223003/60001
4 years, 5 months ago (2016-07-14 21:11:41 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 21:13:02 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/970587bf0ed73807632be7b0f349a96995cee4ec

Powered by Google App Engine
This is Rietveld 408576698