Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: base/task_scheduler/scheduler_worker_pool_impl.h

Issue 2146223002: Refactor WorkerPoolCreationArgs to a Read-Only WorkerPoolParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_worker_pool_impl.h
diff --git a/base/task_scheduler/scheduler_worker_pool_impl.h b/base/task_scheduler/scheduler_worker_pool_impl.h
index 935c79a80c5f000b549628399e0a51dc1180f1ce..1c809241cde1a508931e24b5fd2c37bd45beeeaf 100644
--- a/base/task_scheduler/scheduler_worker_pool_impl.h
+++ b/base/task_scheduler/scheduler_worker_pool_impl.h
@@ -34,6 +34,7 @@ namespace internal {
class DelayedTaskManager;
class TaskTracker;
+class WorkerPoolParams;
// A pool of workers that run Tasks. This class is thread-safe.
class BASE_EXPORT SchedulerWorkerPoolImpl : public SchedulerWorkerPool {
@@ -52,19 +53,14 @@ class BASE_EXPORT SchedulerWorkerPoolImpl : public SchedulerWorkerPool {
// JoinForTesting() has returned.
~SchedulerWorkerPoolImpl() override;
- // Creates a SchedulerWorkerPoolImpl labeled |name| with up to |max_threads|
- // threads of priority |thread_priority|. |io_restriction| indicates whether
- // Tasks on the constructed worker pool are allowed to make I/O calls.
- // |re_enqueue_sequence_callback| will be invoked after a worker of this
- // worker pool tries to run a Task. |task_tracker| is used to handle shutdown
- // behavior of Tasks. |delayed_task_manager| handles Tasks posted with a
- // delay. Returns nullptr on failure to create a worker pool with at least one
- // thread.
+ // Creates a SchedulerWorkerPoolImpl following the |worker_pool_params|
+ // specification. |re_enqueue_sequence_callback| will be invoked after a
+ // worker of this worker pool tries to run a Task. |task_tracker| is used to
+ // handle shutdown behavior of Tasks. |delayed_task_manager| handles Tasks
+ // posted with a delay. Returns nullptr on failure to create a worker pool
+ // with at least one thread.
static std::unique_ptr<SchedulerWorkerPoolImpl> Create(
- StringPiece name,
- ThreadPriority thread_priority,
- size_t max_threads,
- IORestriction io_restriction,
+ const WorkerPoolParams& worker_pool_params,
const ReEnqueueSequenceCallback& re_enqueue_sequence_callback,
TaskTracker* task_tracker,
DelayedTaskManager* delayed_task_manager);

Powered by Google App Engine
This is Rietveld 408576698