Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: base/task_scheduler/task_scheduler_impl_unittest.cc

Issue 2146223002: Refactor WorkerPoolCreationArgs to a Read-Only WorkerPoolParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR Feedback Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/task_scheduler_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/task_scheduler_impl_unittest.cc
diff --git a/base/task_scheduler/task_scheduler_impl_unittest.cc b/base/task_scheduler/task_scheduler_impl_unittest.cc
index c14056ca670053a6c1f566a6ee19eca240f2feda..91f6986725f8396d0ff9497658eb9f5a2de95b53 100644
--- a/base/task_scheduler/task_scheduler_impl_unittest.cc
+++ b/base/task_scheduler/task_scheduler_impl_unittest.cc
@@ -16,6 +16,7 @@
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/synchronization/waitable_event.h"
+#include "base/task_scheduler/scheduler_worker_pool_params.h"
#include "base/task_scheduler/task_traits.h"
#include "base/task_scheduler/test_task_factory.h"
#include "base/threading/platform_thread.h"
@@ -158,30 +159,31 @@ class TaskSchedulerImplTest
TaskSchedulerImplTest() = default;
void SetUp() override {
- using IORestriction = SchedulerWorkerPoolImpl::IORestriction;
+ using IORestriction = SchedulerWorkerPoolParams::IORestriction;
- std::vector<TaskSchedulerImpl::WorkerPoolCreationArgs> worker_pools;
+ std::vector<SchedulerWorkerPoolParams> params_vector;
- ASSERT_EQ(BACKGROUND_WORKER_POOL, worker_pools.size());
- worker_pools.push_back({"TaskSchedulerBackground",
- ThreadPriority::BACKGROUND,
- IORestriction::DISALLOWED, 1U});
+ ASSERT_EQ(BACKGROUND_WORKER_POOL, params_vector.size());
+ params_vector.emplace_back("TaskSchedulerBackground",
+ ThreadPriority::BACKGROUND,
+ IORestriction::DISALLOWED, 1U);
- ASSERT_EQ(BACKGROUND_FILE_IO_WORKER_POOL, worker_pools.size());
- worker_pools.push_back({"TaskSchedulerBackgroundFileIO",
- ThreadPriority::BACKGROUND, IORestriction::ALLOWED,
- 3U});
+ ASSERT_EQ(BACKGROUND_FILE_IO_WORKER_POOL, params_vector.size());
+ params_vector.emplace_back("TaskSchedulerBackgroundFileIO",
+ ThreadPriority::BACKGROUND,
+ IORestriction::ALLOWED, 3U);
- ASSERT_EQ(FOREGROUND_WORKER_POOL, worker_pools.size());
- worker_pools.push_back({"TaskSchedulerForeground", ThreadPriority::NORMAL,
- IORestriction::DISALLOWED, 4U});
+ ASSERT_EQ(FOREGROUND_WORKER_POOL, params_vector.size());
+ params_vector.emplace_back("TaskSchedulerForeground",
+ ThreadPriority::NORMAL,
+ IORestriction::DISALLOWED, 4U);
- ASSERT_EQ(FOREGROUND_FILE_IO_WORKER_POOL, worker_pools.size());
- worker_pools.push_back({"TaskSchedulerForegroundFileIO",
- ThreadPriority::NORMAL, IORestriction::ALLOWED,
- 12U});
+ ASSERT_EQ(FOREGROUND_FILE_IO_WORKER_POOL, params_vector.size());
+ params_vector.emplace_back("TaskSchedulerForegroundFileIO",
+ ThreadPriority::NORMAL, IORestriction::ALLOWED,
+ 12U);
- scheduler_ = TaskSchedulerImpl::Create(worker_pools,
+ scheduler_ = TaskSchedulerImpl::Create(params_vector,
Bind(&GetThreadPoolIndexForTraits));
ASSERT_TRUE(scheduler_);
}
« no previous file with comments | « base/task_scheduler/task_scheduler_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698