Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: base/task_scheduler/scheduler_worker_pool_impl_unittest.cc

Issue 2146223002: Refactor WorkerPoolCreationArgs to a Read-Only WorkerPoolParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR Feedback Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_worker_pool_impl_unittest.cc
diff --git a/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc b/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc
index 7766f72e0d2aecc16b2c085a1fae8c522d59ce18..9c96883058e4c5481ab4091cd81ac8dd1cf0bcaa 100644
--- a/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc
+++ b/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc
@@ -21,6 +21,7 @@
#include "base/synchronization/waitable_event.h"
#include "base/task_runner.h"
#include "base/task_scheduler/delayed_task_manager.h"
+#include "base/task_scheduler/scheduler_worker_pool_params.h"
#include "base/task_scheduler/sequence.h"
#include "base/task_scheduler/sequence_sort_key.h"
#include "base/task_scheduler/task_tracker.h"
@@ -39,7 +40,7 @@ const size_t kNumWorkersInWorkerPool = 4;
const size_t kNumThreadsPostingTasks = 4;
const size_t kNumTasksPostedPerThread = 150;
-using IORestriction = SchedulerWorkerPoolImpl::IORestriction;
+using IORestriction = SchedulerWorkerPoolParams::IORestriction;
class TestDelayedTaskManager : public DelayedTaskManager {
public:
@@ -63,8 +64,10 @@ class TaskSchedulerWorkerPoolImplTest
void SetUp() override {
worker_pool_ = SchedulerWorkerPoolImpl::Create(
- "TestWorkerPoolWithFileIO", ThreadPriority::NORMAL,
- kNumWorkersInWorkerPool, IORestriction::ALLOWED,
+ SchedulerWorkerPoolParams("TestWorkerPoolWithFileIO",
+ ThreadPriority::NORMAL,
+ IORestriction::ALLOWED,
+ kNumWorkersInWorkerPool),
Bind(&TaskSchedulerWorkerPoolImplTest::ReEnqueueSequenceCallback,
Unretained(this)),
&task_tracker_, &delayed_task_manager_);
@@ -363,7 +366,8 @@ TEST_P(TaskSchedulerWorkerPoolImplIORestrictionTest, IORestriction) {
DelayedTaskManager delayed_task_manager(Bind(&DoNothing));
auto worker_pool = SchedulerWorkerPoolImpl::Create(
- "TestWorkerPoolWithParam", ThreadPriority::NORMAL, 1U, GetParam(),
+ SchedulerWorkerPoolParams("TestWorkerPoolWithParam",
+ ThreadPriority::NORMAL, GetParam(), 1U),
Bind(&NotReachedReEnqueueSequenceCallback), &task_tracker,
&delayed_task_manager);
ASSERT_TRUE(worker_pool);
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_impl.cc ('k') | base/task_scheduler/scheduler_worker_pool_params.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698